forked from servo/servo
-
Notifications
You must be signed in to change notification settings - Fork 0
Reviewer
Josh Matthews edited this page Jun 9, 2016
·
1 revision
There are a few key things we look for when asking Servo contributors to become reviewers. Surprisingly, none of them are an understanding of the full breadth of code in Servo:
- Get to reviews soon! You don’t have to complete the review, necessarily. Do a first pass, or if you really have no time then hand it off to someone else quickly.
- Be courteous - you are a personal connection to Mozilla and you should be as welcoming as Mozilla is supposed to be.
- Know your limits. Don’t review anything if you don’t understand the code it deals with. Instead, help the reviewee find an alternate reviewer.
- You don’t get to demand that the reviewee re-write the patch in your preferred style. If their code meets style guidelines, fixes the bug, and is efficient enough, don’t waste people’s time by re-architecting it.
All of these elements can be observed through the code the potential reviewer is writing, and letting them review smaller patches by experienced contributors.
(Liberally adapted from Dave Townsend's blog post about Firefox reviewers)