-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSLX DMA: Implement FIFO and CSR #1215
base: main
Are you sure you want to change the base?
Conversation
0c42f15
to
89c11af
Compare
89c11af
to
8e42c06
Compare
d506b47
to
c35221c
Compare
c35221c
to
50ac086
Compare
@rw1nkler suggested that could also be a good standalone thing to review and land soonish. |
@hongted mentioned that @grebe might be interested to look at the fifo implementation in that PR: |
0646e7d
to
035355f
Compare
@proppy I agree, PR is ready for review. I force pushed today to include last changes and GH workflows. |
.github/actions/build/action.yml
Outdated
@@ -0,0 +1,26 @@ | |||
name: build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we inline those actions in a dedicated zstd workflow for now? (and maybe later have a separate PR for refactoring the existing workflows w/ composite actions); I agree that we could have a better architecture of our workflows (maybe we could have a separate https://github.com/google/xls/issues/new?template=enhancement-proposal.yml for this?) but I think that it's orthogonal to the work being review here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the workflows to create a simpler, flat configuration. If you wish to review the artifacts: https://github.com/antmicro/xls/actions/runs/8551896740
035355f
to
8f60d2c
Compare
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
8f60d2c
to
a32ee39
Compare
DSLX DMA
This PR implements modules needed to build the DSLX DMA as described in issue #1208.
Ready for review
TODO:
Writer start
andReader start
bitWriter sync disable
andReader sync disable
Writer loop mode
andReader loop mode
Writer busy
andReader busy
bitWriter mask
andReader mask
bitWriter interrupt
andReader interrupt
1
when interrupt has occurred (done)1
to clear interruptN >> L
(overflow condition)Implementation details
See README.md included in this PR for implementation details
Limitations
Current CI configuration fails:
main_controller.x
file, then the test passes. There are also other tests of the main controller that work standalone, but fail once at least 2 procs are uncommented