Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen for Ares #135

Draft
wants to merge 12 commits into
base: status
Choose a base branch
from
Draft

Codegen for Ares #135

wants to merge 12 commits into from

Conversation

eamsden
Copy link
Collaborator

@eamsden eamsden commented Nov 24, 2023

Supersedes #89 with much cleaner history and rebased onto status. @matthew-levan work on integrating the codegen into rust-side Ares should happen here.

Edward TODO

  • Fix missing cases in linearizer
  • cons/decons and move renaming in linearizer
  • %phi and %hip elimination in linearizer (minimize register set?)
  • move +wink to a separate hoon file or even generator (make sure axes are re-established in rust-side code)
  • tag top-level codegen core with an incrementing version constant, and check it on rust side (make sure axes are re-established in rust-side code)
  • In-depth review of rust-side execution code
  • Thoroughly review linearizer crash and poison logic
  • Thread "which interpreter" enum through context
  • Thread slow stack through jets and jet helpers
  • Add to or delete from hill hamt by diffs emitted from +poke in codegen core
  • Make jets and helpers use "which interpreter" enum

rust/ares/src/main.rs Outdated Show resolved Hide resolved
rust/ares/src/codegen.rs Outdated Show resolved Hide resolved
rust/ares/src/codegen.rs Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@eamsden eamsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthew-levan there are a lot of instances of missing break statements where errors should be returned but won't be. A couple of examples are below but the error is pervasive. Please correct all instances.

rust/ares/src/codegen.rs Outdated Show resolved Hide resolved
rust/ares/src/codegen.rs Outdated Show resolved Hide resolved
@joemfb joemfb mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants