-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ares codegen redux #238
Draft
joemfb
wants to merge
68
commits into
status
Choose a base branch
from
jb/codegen-perf
base: status
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ares codegen redux #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on and supersedes #135. The diff relative to that PR is here: eamsden/codegen...jb/codegen-perf
Changes include:
The spot-hint handling and associated output provide a means for understanding incremental analysis results for a piece nock (when the hints are present). The additional memoization makes it possible to analyze massive instances of mutual recursion (like
+ut
). The refactoring supports profiling in vere with-j
.The changes relative to #135 are best understood in pieces:
There are currently a handful of false positive "meloization" hits in the analysis of
hoon.hoon
. We have safety-checks in finalization that properly detect these, but we don't yet correctly turn all ancestor call sites indirect. This and other TODOs are noted in 8805494. This PR will remain a draft until those issues are resolved.