Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

By default, ExecShell will add an io.Discard #20

Merged
merged 2 commits into from
Jun 30, 2020
Merged

By default, ExecShell will add an io.Discard #20

merged 2 commits into from
Jun 30, 2020

Commits on Jun 29, 2020

  1. By default, ExecShell will add and io.Discard 

    CombinedOutput will be `io.Discard` except when someone passed
IgnoreResults. Seems like a good way of throwing "async" command calls
that doesn't need to be checked after execution.
    Ridai Govinda Pombo committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    c6392c6 View commit details
    Browse the repository at this point in the history

  2. Address PR feedback 

    No "IgnoreResults" option, too confusing.
We only use `ioutil.Discard` when starting the exection

Tests don't check `err`, as asked in #17

[ch1592]
    Ridai Govinda Pombo committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    bc3103e View commit details
    Browse the repository at this point in the history