By default, ExecShell will add an io.Discard #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CombinedOutput will be `io.Discard` except when someone passed IgnoreResults. Seems like a good way of throwing "async" command calls that doesn't need to be checked after execution.
beholders-eye
changed the title
|
I dug into the fsouza/go-dockerclient source and discovered that the underlying issue is that without attaching stdout/stderr handles, there's a synchronization bug. I've reported upstream as fsouza/go-dockerclient#838. You can see for yourself by adding the following to the end of if results.Running {
return fmt.Errorf("execute shell command in container %s: yup it's a sync problem", containerID)
}My recommendation is that this shouldn't be a separate option. If the caller of |
No "IgnoreResults" option, too confusing. We only use `ioutil.Discard` when starting the exection Tests don't check `err`, as asked in #17 [ch1592]
|
PTAL @zombiezen |
jamesnaftel
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CombinedOutput will be
io.Discardexcept when someone passedIgnoreResults. Seems like a good way of throwing "async" command calls
that doesn't need to be checked after execution.