Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3-aiohttp/3.11.9 package update #35586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 1, 2024

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Dec 1, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 1, 2024

Gen AI suggestions to solve the build error:

Based on the build error, I'll analyze and provide a solution:

• Detected Error:

cc1: fatal error: aiohttp/_websocket/mask.c: No such file or directory
compilation terminated.
error: command '/usr/local/bin/x86_64-pc-linux-gnu-gcc' failed with exit code 1

• Error Category: Build Configuration

• Failure Point: Cython compilation step during wheel building for Python 3.10

• Root Cause Analysis:
The build is failing because the Cython-generated C files are not being created before the compilation step. This is happening because the Python Setup step isn't properly generating the Cython files for the websocket mask module.

• Suggested Fix:
Modify the Python Setup step in the melange YAML to explicitly generate all required Cython files:

- name: Python Setup
  runs: |
    mkdir -p .git
    python${{range.key}} tools/gen.py
    python${{range.key}} -m cython -3 aiohttp/_websocket/mask.pyx -I aiohttp/_websocket
    python${{range.key}} -m cython -3 aiohttp/*.pyx -I aiohttp
    rm -rf .git

• Explanation:
The original build step wasn't generating the C file for the websocket mask module. By explicitly running Cython on the websocket mask module before the main modules, we ensure all necessary C files are generated before compilation begins.

• Additional Notes:

  • The .git directory creation/deletion is maintained for compatibility with setuptools_scm
  • The order of Cython compilation is important - compile websocket modules first
  • This matches the package's build process as seen in their source repository

• References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant