Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3-aiohttp/3.11.8 package update #35383

Closed
wants to merge 1 commit into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Nov 27, 2024

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Nov 27, 2024
Copy link
Contributor Author

octo-sts bot commented Nov 27, 2024

Gen AI suggestions to solve the build error:

Based on the error output, I'll provide a detailed analysis and solution:

• Detected Error:

cc1: fatal error: aiohttp/_websocket/mask.c: No such file or directory
compilation terminated.
error: command '/usr/local/bin/x86_64-pc-linux-gnu-gcc' failed with exit code 1

• Error Category: Build Configuration

• Failure Point: Cython compilation step during wheel building for Python 3.10

• Root Cause Analysis:
The build is failing because the Cython-generated C files are not being created before the compilation attempt. This is likely due to the order of operations in the Python Setup step.

• Suggested Fix:
Modify the "Python Setup" pipeline step to ensure Cython generates all necessary files:

- name: Python Setup
  runs: |
    mkdir -p .git
    python${{range.key}} -m pip install setuptools wheel
    python${{range.key}} tools/gen.py
    python${{range.key}} -m cython -3 aiohttp/*.pyx aiohttp/_websocket/*.pyx -I aiohttp
    rm -rf .git

• Explanation:

  1. The original error occurs because the mask.c file isn't generated before compilation
  2. We need to explicitly include the _websocket directory in the Cython compilation
  3. Adding the _websocket/*.pyx pattern ensures all Cython files are properly compiled
  4. The -I flag ensures proper include path resolution

• Additional Notes:

  • The build system needs to generate C files from .pyx files before compilation
  • The _websocket module contains additional Cython code that wasn't being processed
  • This is a common issue when building Cython extensions with multiple directories

• References:

@octo-sts octo-sts bot closed this Dec 1, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 1, 2024

superseded by #35586

@octo-sts octo-sts bot deleted the wolfictl-935b3230-d4af-44c3-9491-a496903540c2 branch December 2, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant