Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3-aiohttp/3.11.7 package update #34875

Closed
wants to merge 1 commit into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Nov 21, 2024

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Nov 21, 2024
Copy link
Contributor Author

octo-sts bot commented Nov 21, 2024

Gen AI suggestions to solve the build error:

Based on the build error, I'll provide a detailed analysis and solution:

• Detected Error:

cc1: fatal error: aiohttp/_websocket/mask.c: No such file or directory
compilation terminated.
error: command '/usr/local/bin/x86_64-pc-linux-gnu-gcc' failed with exit code 1

• Error Category: Build Configuration

• Failure Point: Building the Cython extension aiohttp._websocket.mask

• Root Cause Analysis:
The build is failing because the Cython-generated C file for the websocket mask module is missing. This happens because the build process needs to generate C files from Cython sources before compilation.

• Suggested Fix:
Modify the Python Setup step in the melange YAML to ensure Cython generates all required C files:

- name: Python Setup
  runs: |
    mkdir -p .git
    python${{range.key}} tools/gen.py
    python${{range.key}} -m cython -3 aiohttp/*.pyx aiohttp/_websocket/*.pyx -I aiohttp
    rm -rf .git

• Explanation:
The current setup only processes Cython files in the main aiohttp directory, but misses the ones in the _websocket subdirectory. By adding aiohttp/_websocket/*.pyx to the Cython command, we ensure all required C files are generated before the build process begins.

• Additional Notes:

  1. The websocket mask module is a performance-critical component that needs to be compiled as a C extension
  2. The build requires proper Cython file generation for all .pyx files in the project
  3. The error occurs during wheel building because the C source file wasn't generated in the previous step

• References:

The fix addresses the immediate build failure by ensuring all necessary Cython files are properly processed before the compilation step begins.

@hbh7 hbh7 assigned hbh7 and unassigned hbh7 Nov 25, 2024
@octo-sts octo-sts bot closed this Nov 27, 2024
Copy link
Contributor Author

octo-sts bot commented Nov 27, 2024

superseded by #35383

@octo-sts octo-sts bot deleted the wolfictl-fbe576e9-a516-46ba-aab8-0439124b4294 branch November 28, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants