-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Render Blocking Status to PerformanceResourceTiming #327
Conversation
Thanks @abinpaul1!! @caribouW3 - What do we need to appease the IPR bots here? Should Abin join the WG as an invited expert? |
Are we in situation 2. b described here: https://github.com/w3c/Guide/blob/master/process/non-participant-commitment.md |
We discussed this on the WG call yesterday. @bdekoz @sefeng211 @achristensen07 - I'd love y'all's thoughts on this |
Left a relevant comment on the Fetch PR that would impact this PR as well/ |
2f26e20
to
9b99039
Compare
Any WPTs for this? |
Great idea, though I believe this would be confusing with preloads until we resolve #303. If you preload a stylesheet and then load it as render-blocking, it would currently appear as not render-blocking because currently we don't expose preload-consuming requests in resource timing. |
It's being added over at https://chromium-review.googlesource.com/c/chromium/src/+/3709521 |
It's probably failing because the Fetch PR is not merged yet. I want that merged first and to get some understanding about #327 (comment) before proceeding |
I agree that this would be confusing initially, but don't know if we want to block this work on solving preloads. |
Sounds ok, just wanted to get that conversation started (this PR is blocked on the fetch PR) |
This supports the addition of a render blocking status field to PerformanceResourceTiming. Further details are available at w3c/resource-timing#327.
Changed the type of render blocking status from string to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Introducing a render blocking status field. (#262)
Fetch changes : whatwg/fetch#1449
HTML changes: whatwg/html#7979Explainer : https://github.com/abinpaul1/resource-timing/blob/render-blocking-status-explainer/Explainer/Render_Blocking_Status.md
Preview | Diff