-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documenting renderBlockingStatus in Resource Timing #19325
Conversation
Hi @abinpaul1, thanks for opening the PR. I'm just checking if you're planning to pick this one up again or how you'd like to proceed. Thanks a lot :) |
I was thinking I'd have to wait for Chrome 107 to ship which would be the first browser release to have this enabled. I'm happy to continue working on this right away. Please feel free to start a review for this and I can adjust it based on feedback or I'm also open to handing it over if thats preferred. |
files/en-us/web/api/performanceresourcetiming/renderBlockingStatus/index.md
Outdated
Show resolved
Hide resolved
Thanks a lot, I just had a look through the Chrome bug and it looks like it's expected to ship soon, is that right? Feel free to ping me to have another look! :) |
Yes, stable is expected to ship towards end of October. I am going ahead and marking the PR as ready for review. |
OK thanks a lot. There will be some downtime from the team during the next week or so; we will get to this afterwards. I'm happy to pick it up then. |
@bsmth I'm not able to get around an error when I add this new document for renderBlockingStatus. I am trying to keep it similar to how all the other fields in Resource Timing are added, but I get this error.
Mainly the document isnt being picked up for some reason. Navigating to |
It could be a case-sensitivity thing on the parent directory for the document. I can take a look shortly |
…atus/index.md to files/en-us/web/api/performanceresourcetiming/renderblockingstatus/index.md
Preview URLs
(this comment was updated 2022-11-02 10:44:00.349468) |
@abinpaul1 this is fixed now in ac79f03, the parent dir is case-sensitive |
Cool! Thanks |
files/en-us/web/api/performanceresourcetiming/renderblockingstatus/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performanceresourcetiming/renderblockingstatus/index.md
Outdated
Show resolved
Hide resolved
I tested in Chrome |
I've opened a PR for adding the compat data : mdn/browser-compat-data#18046 |
oh nice, you beat me to it 🙌🏻 |
Hey @bsmth, Are we good to merge this? |
Hi @abinpaul1, I think the corresponding BCD PR has to be merged first. Once that's landed I think we're ready to go here. |
BCD for this is merged, this PR can be merged when this is deployed (likely today). |
This should be mergeable now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abinpaul1, going to merge shortly
Summary
New field
renderBlockingStatus
in PerfomanceResourceTiming to indicate the render-blocking nature of a resource. The attribute takes away the burden of having to rely on complex heurestics to determine which resources were actually render-blocking and provides a direct signal from the browser.Explainer : https://github.com/abinpaul1/resource-timing/blob/render-blocking-status-explainer/Explainer/Render_Blocking_Status.md
Spec changes : w3c/resource-timing#327
Motivation
Adding documentation for new attribute
renderBlockingStatus
introduced to Resource Timing. Adding sample code to demonstrate usage of the attribute.Supporting details
CR Bug : https://bugs.chromium.org/p/chromium/issues/detail?id=1337256
Chrome status entry : https://chromestatus.com/feature/5166965277589504
Related issues
Metadata