-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cssom-1] Merge constructable stylesheets into CSSOM (https://lists.w3.org/Archives/Public/www-style/2020Feb/0012.html) #6304
Conversation
Any thoughts here? @emilio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry for the lag. This looks sensible to me. Maybe @tabatkins has some editorial comments or something? But otherwise this seems good to merge to me.
I assume the DocumentOrShadowRoot.adoptedStyleSheets
etc definitions should get merged-in later?
Great, thanks! I'm happy to make modifications, just let me know. As for |
Any further thoughts @emilio @tabatkins ? Anything else I need to do in order to get this landed? |
Friendly ping @emilio and @tabatkins, thanks! |
LGTM, thanks for this @mfreed7 (and sorry, I'm really slow with gh notifications lately :/) |
No problem at all (I'm even more guilty of that) and thanks for merging this. I will now get started on the other parts, mentioned in the original comment here. |
It was spec'd a long time ago: w3c/csswg-drafts#6304
It was spec'd a long time ago: w3c/csswg-drafts#6304
…ative, a=testonly Automatic update from web-platform-tests Make CSSStyleSheet baseURL test non-tentative (#45903) It was spec'd a long time ago: w3c/csswg-drafts#6304 -- wpt-commits: 7bea4f8a47e6f245c01e2b7cd740df5895a1727b wpt-pr: 45903
…ative, a=testonly Automatic update from web-platform-tests Make CSSStyleSheet baseURL test non-tentative (#45903) It was spec'd a long time ago: w3c/csswg-drafts#6304 -- wpt-commits: 7bea4f8a47e6f245c01e2b7cd740df5895a1727b wpt-pr: 45903
…ative, a=testonly Automatic update from web-platform-tests Make CSSStyleSheet baseURL test non-tentative (#45903) It was spec'd a long time ago: w3c/csswg-drafts#6304 -- wpt-commits: 7bea4f8a47e6f245c01e2b7cd740df5895a1727b wpt-pr: 45903
[cssom-1] Merge constructable stylesheets into CSSOM (https://lists.w3.org/Archives/Public/www-style/2020Feb/0012.html)
This is a first PR to merge the Constructable Stylesheets proposal into the CSSOM spec. This was resolved in Feb 2020: https://lists.w3.org/Archives/Public/www-style/2020Feb/0012.html. There are several sub-resolutions there, a few of which are handled here:
either @emilio or @rakina@mfreed7 doing so)....and a few of which will follow this PR:
CSSStyleSheet
base URL
into account. (Suggestions appreciated for where exactly these specs live. These two perhaps? referrer-policy css-values-4)a CSSStyleSheetList and add the appropriate add/remove methods to the document or shadowRoot interfacean ObservableArray.Closes #3433, Closes WICG/construct-stylesheets#102, Closes WICG/construct-stylesheets#90
P.S. This is my first CSSWG PR. Please go easy on me and let me know what I can do better. 😄