Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Moving the constructable stylesheets post to web.dev #5968

Merged

Conversation

rachelandrew
Copy link
Collaborator

@netlify
Copy link

netlify bot commented Aug 13, 2021

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: f891988

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/6128c22850e42a00071b774e

😎 Browse the preview: https://deploy-preview-5968--web-dev-staging.netlify.app

@google-cla google-cla bot added the cla: yes Contributor has signed the CLA label Aug 13, 2021
@rachelandrew rachelandrew marked this pull request as draft August 13, 2021 07:30
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/blog/constructable-stylesheets/index.md

  • This file passed all of our automated Markdown audits.

1 similar comment
@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/blog/constructable-stylesheets/index.md

  • This file passed all of our automated Markdown audits.

@rachelandrew
Copy link
Collaborator Author

@developit I'm moving this post to web.dev. I updated the browser info to mention that constructable stylesheets are now behind a flag in Firefox, and also linked to the methods on MDN as I documented them a couple of weeks ago.

I saw that the constructable stylesheets spec has been merged into CSSOM in w3c/csswg-drafts#6304 so wondered if it would be appropriate to update some of the links to the draft, rather than the original note.

Let me know if there is anything else you think should be updated (or do so directly in the PR).

@developit
Copy link
Contributor

This looks great @rachelandrew! Agreed about the link updates - do you want me to do that?

@rachelandrew
Copy link
Collaborator Author

This looks great @rachelandrew! Agreed about the link updates - do you want me to do that?

If you have time that would be great!

@developit
Copy link
Contributor

Alrighty, I've updated a few of the links to point to the draft version of the spec (these changes haven't landed in the published CSSOM-1 yet). I left a couple links to Mason's explainer that don't have corresponding developer-facing explanations in the spec.

@rachelandrew rachelandrew marked this pull request as ready for review August 24, 2021 06:12
Copy link
Contributor

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to both of you for this work!

Does this mean that at some point the MDN will get a page on adoptedStyleSheets?

@stale
Copy link

stale bot commented Nov 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. To prevent this from happening, leave a comment.

@stale stale bot added the stale label Nov 29, 2021
@stale
Copy link

stale bot commented Dec 6, 2021

Closing this issue because it has been marked as stale for more than 7 days.

@stale stale bot closed this Dec 6, 2021
@rachelandrew rachelandrew reopened this Jan 28, 2022
@stale stale bot removed the stale label Jan 28, 2022
@rachelandrew rachelandrew added the $-presubmit Add label to run presubmit tests. label Feb 23, 2022
@rachelandrew rachelandrew merged commit 167a65b into GoogleChrome:main Feb 23, 2022
@rachelandrew rachelandrew deleted the migrate-constructable-stylesheets branch February 23, 2022 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
$-presubmit Add label to run presubmit tests. cla: yes Contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants