-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: last transaction #481
Merged
mohandast52
merged 12 commits into
refactor/multi-chain-support-frontend
from
mohan/transaction-history
Nov 22, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
41aec50
feat: enhance StakingContractSection to use selected service's chain …
mohandast52 6eaa540
feat: update SetupWelcomeLogin to utilize selected service's chain ID…
mohandast52 931e130
feat: refactor Setup components for improved chain support and addres…
mohandast52 d6719d6
feat: enhance SetupCreateSafe and SetupEoaFunding components for impr…
mohandast52 a92b8d1
fix: remove redundant text and clean up SetupRestore component layout
mohandast52 e846556
Update frontend/components/SetupPage/Create/SetupEoaFunding.tsx
mohandast52 2d63c70
Update frontend/components/SetupPage/Create/SetupEoaFunding.tsx
mohandast52 5e23c2b
Update frontend/components/SetupPage/Create/SetupEoaFunding.tsx
mohandast52 5d8b82e
feat: refactor Setup components to use master wallet balances and sim…
mohandast52 6d7a332
Merge branch 'mohan/refactor-onboarding' of github.com-personal:valor…
mohandast52 920a53f
refactor: simplify service configuration handling and remove unused u…
mohandast52 e286eba
Merge branch 'refactor/multi-chain-support-frontend' of github.com-pe…
mohandast52 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this overkill and better to extract from hook? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with either approach for now, we can optimize at later point!
My preference atm is to use hooks to isolate children from parent changes where we can, though this may eventually lead to some performance issues. Yet to hit any so far however, but will memoize components/props once the time comes!