feat: last transaction #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ID for contract details link
… for master safe and balance checks
…oved error handling and user feedback
Co-authored-by: Josh Miller <31908788+truemiller@users.noreply.github.com>
Co-authored-by: Josh Miller <31908788+truemiller@users.noreply.github.com>
Co-authored-by: Josh Miller <31908788+truemiller@users.noreply.github.com>
…y-xyz/olas-operate-app into mohan/refactor-onboarding
…rsonal:valory-xyz/olas-operate-app into mohan/transaction-history
mohandast52
commented
Nov 21, 2024
| @@ -76,7 +75,8 @@ export const AgentRunningButton = () => { | |||
| Agent is working | |||
| </Paragraph> | |||
| )} | |||
| <LastTransaction /> | |||
|
|
|||
| <LastTransaction serviceConfigId={serviceConfigId} /> | |||
There was a problem hiding this comment.
is this overkill and better to extract from hook? 🤔
There was a problem hiding this comment.
Fine with either approach for now, we can optimize at later point!
My preference atm is to use hooks to isolate children from parent changes where we can, though this may eventually lead to some performance issues. Yet to hit any so far however, but will memoize components/props once the time comes!
Tanya-atatakai
approved these changes
Nov 22, 2024
mohandast52
merged commit ae81ebd
into
refactor/multi-chain-support-frontend
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply