feat: Introduce kraft pkg show
#536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MdSahil-oss
changed the title
show for command kraft pkgshow for command kraft pkg
MdSahil-oss
force-pushed
the
pkg-show
branch
3 times, most recently
from
a3f9d59
to
3361021
Compare
craciunoiuc
reviewed
Jul 1, 2023
MdSahil-oss
force-pushed
the
pkg-show
branch
3 times, most recently
from
e73a4b4
to
ff0108e
Compare
MdSahil-oss
force-pushed
the
pkg-show
branch
9 times, most recently
from
be4447d
to
93602c8
Compare
nderjung
changed the title
show for command kraft pkgkraft pkg show
MdSahil-oss
force-pushed
the
pkg-show
branch
2 times, most recently
from
8c3b5a7
to
5cab90f
Compare
craciunoiuc
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Hey @MdSahil-oss
Tried it out a final time and works fine. Some final comments from my side regarding messages passed to the user.
After this we'll merge, I promise 🤞
Signed-off-by: sahil <mohdssahil1@gmail.com>
MdSahil-oss
force-pushed
the
pkg-show
branch
from
5cab90f
to
4db9276
Compare
craciunoiuc
approved these changes
Dec 17, 2023
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
nderjung
added a commit
to nderjung/kraftkit
that referenced
this pull request
Dec 19, 2023
This commit effectively reverses unikraft#536 in favour of using the existing package manager's `Catalog` method. Since packages already expose a `Columns` method, this information can be used to "show" information about a specific named package. Simultaneously, the `Catalog` method and the information returned by the implementing `pack.Package` works for all current package managers. Secondly, wrap the invocations of `Catalog` with `tui.processtree` which is useful when used with the `-u|--update` flag for very long wait times and to help indicate to the user the longevity of the invocation. Finally, utilize the newly introduced `PrintPackages` method which was previously ripped from `kraft pkg ls`. Signed-off-by: Alexander Jung <alex@unikraft.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
Added a subcommand
showfor commandkraft pkg.Now any package information can be seen with the help of command
kraft pkg show packNamein the format of YAML|JSON .