Update VS Code IDE extension to function properly with new Go-based KraftKit #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MdSahil-oss
changed the title
MdSahil-oss
force-pushed
the
golang-kraftkit
branch
from
2d098e2
to
9b8a63a
Compare
MdSahil-oss
changed the title
MdSahil-oss
changed the title
MdSahil-oss
force-pushed
the
golang-kraftkit
branch
from
9b8a63a
to
e0b264f
Compare
MdSahil-oss
force-pushed
the
golang-kraftkit
branch
from
efee5ea
to
c9d60b3
Compare
MdSahil-oss
changed the title
craciunoiuc
reviewed
Aug 9, 2023
craciunoiuc
reviewed
Aug 9, 2023
craciunoiuc
reviewed
Aug 9, 2023
craciunoiuc
reviewed
Aug 9, 2023
craciunoiuc
reviewed
Aug 9, 2023
MdSahil-oss
force-pushed
the
golang-kraftkit
branch
from
166467d
to
0bc0506
Compare
MdSahil-oss
force-pushed
the
golang-kraftkit
branch
4 times, most recently
from
02f0722
to
5e44e19
Compare
MdSahil-oss
changed the title
MdSahil-oss
changed the title
craciunoiuc
reviewed
Aug 26, 2023
Signed-off-by: sahil <mohdssahil1@gmail.com>
Signed-off-by: Md Sahil <mohdssahil1@gmail.com>
MdSahil-oss
force-pushed
the
golang-kraftkit
branch
2 times, most recently
from
ea7fbbb
to
9af6db9
Compare
|
I created a list of dependencies from kraftkit that need to go in first: |
MdSahil-oss
force-pushed
the
golang-kraftkit
branch
2 times, most recently
from
e977b4c
to
49305bc
Compare
|
Sorry it's taking so much, we are currently stuck on two PRs that change quite lot. Afterwards, your PR series will have priority 😓 |
|
No Problem @craciunoiuc Merge Whenever it is possible :) |
MdSahil-oss
force-pushed
the
golang-kraftkit
branch
from
49305bc
to
fe6d861
Compare
MdSahil-oss
force-pushed
the
golang-kraftkit
branch
from
fe6d861
to
f098c36
Compare
craciunoiuc
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Hey @MdSahil-oss, did a pass now and found several typos, please address them when you have time
We will revisit this once everything is merged in kraftkit. Afterwards I'll ask you to put aside 1h and go through the whole PR and hunt for typos, formatting, and spelling.
I'll then give it a final try and then merge it
Signed-off-by: Md Sahil <mohdssahil1@gmail.com>
Signed-off-by: Md Sahil <mohdssahil1@gmail.com>
Signed-off-by: Md Sahil <mohdssahil1@gmail.com>
MdSahil-oss
force-pushed
the
golang-kraftkit
branch
from
360bcbe
to
e683a3a
Compare
craciunoiuc
reviewed
Jan 10, 2024
Signed-off-by: MdSahil-oss <mohdssahil1@gmail.com>
MdSahil-oss
force-pushed
the
golang-kraftkit
branch
from
e683a3a
to
2c42bbc
Compare
craciunoiuc
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Approved-by: Cezar Craciunoiu cezar.craciunoiu@unikraft.io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update VS Code IDE extension to function properly with new Go-based KraftKit