Add claims to Attestation
#70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # src/pypi_attestations/_impl.py
DarkaMaul
commented
Nov 15, 2024
facutuesca
reviewed
Nov 19, 2024
Comment on lines
+208
to
+212
| identifier = int(extension.oid.dotted_string.rsplit(".", 1)[1]) | ||
| if ( | ||
| extension.oid.dotted_string.startswith(fulcio_oid.dotted_string) | ||
| and 8 <= identifier <= 22 | ||
| ): |
There was a problem hiding this comment.
Rathen than dynamically building the list of extension OIDs from .8 to .22 every time claims() is called, I wonder if we should have a constant SUPPORTED_FULCIO_OIDS: list[x509.ObjectIdentifier] which lists them all. WDYT?
Co-authored-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
woodruffw
reviewed
Nov 19, 2024
12 tasks
# Conflicts: # CHANGELOG.md # test/test_impl.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some important points :
sigstore-pythonto decode the value, but this create an implicit transitive dependency onpyasn1. This should probably be added to this package requirements list or modify sigstore-python to expose this information directly.