file-details: small tweaks #17072
Merged
file-details: small tweaks #17072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
miketheman
approved these changes
Nov 13, 2024
di
reviewed
Nov 14, 2024
| {% macro publisher(publ) -%} | ||
| {% if publ.kind == "GitHub" %} | ||
| <p> | ||
| Publisher: <a href="https://github.com/{{ publ.repository }}/blob/HEAD/.github/workflows/{{ publ.workflow }}"> |
There was a problem hiding this comment.
@woodruffw Do we not have the SHA or some other ref to link to instead here?
There was a problem hiding this comment.
We do, although it's packed into the X.509 extensions within the attestation's certificate. I'll do a follow-up PR to extract and present that (along with the other useful stuff at the X.509 layer).
There was a problem hiding this comment.
Tracking: needs trailofbits/pypi-attestations#70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some small tweaks, to link to more things where possible and specialize the handling of
kind == GitHubpublishers (since that's what the MVP supports).Example: