Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy per module #560

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Mypy per module #560

wants to merge 3 commits into from

Conversation

whooo
Copy link
Contributor

@whooo whooo commented Jan 17, 2024

No description provided.

Since [commit][1] in libtpms setting auth values/policies for PCRs are no longer supported.

[1]: stefanberger/libtpms@af4fc0e

Signed-off-by: Erik Larsson <who+github@cnackers.org>
setup.py Fixed Show fixed Hide fixed
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (140ca4a) 91.57% compared to head (a3b354e) 90.86%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/tpm2_pytss/types.py 84.88% 8 Missing and 5 partials ⚠️
src/tpm2_pytss/utils.py 35.29% 6 Missing and 5 partials ⚠️
src/tpm2_pytss/internal/utils.py 79.48% 5 Missing and 3 partials ⚠️
src/tpm2_pytss/ESAPI.py 78.26% 5 Missing ⚠️
src/tpm2_pytss/TCTI.py 86.11% 3 Missing and 2 partials ⚠️
src/tpm2_pytss/constants.py 91.93% 4 Missing and 1 partial ⚠️
src/tpm2_pytss/internal/crypto.py 94.11% 3 Missing and 2 partials ⚠️
src/tpm2_pytss/FAPI.py 96.80% 3 Missing and 1 partial ⚠️
src/tpm2_pytss/TCTISPIHelper.py 82.35% 2 Missing and 1 partial ⚠️
src/tpm2_pytss/fapi_info.py 86.36% 3 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
- Coverage   91.57%   90.86%   -0.72%     
==========================================
  Files          17       17              
  Lines        7017     7101      +84     
  Branches     1012     1032      +20     
==========================================
+ Hits         6426     6452      +26     
- Misses        418      457      +39     
- Partials      173      192      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

setup.py Fixed Show fixed Hide fixed
@whooo whooo force-pushed the mypy-per-module branch 7 times, most recently from 20ca8e3 to b1da22e Compare January 18, 2024 17:55
src/tpm2_pytss/types.py Fixed Show fixed Hide fixed
src/tpm2_pytss/types.py Fixed Show fixed Hide fixed
src/tpm2_pytss/ESAPI.py Fixed Show fixed Hide fixed
src/tpm2_pytss/ESAPI.py Fixed Show fixed Hide fixed
src/tpm2_pytss/FAPI.py Fixed Show fixed Hide fixed
@whooo whooo force-pushed the mypy-per-module branch 2 times, most recently from 6b2d85a to 5d007d9 Compare January 21, 2024 14:57
RSAPrivateNumbers was moved to a rust implementation in 42.0.1.
So inheritance is no longer possible, so turn the class into a
wrapper instead of a subclass.

Fixes tpm2-software#561

Signed-off-by: Erik Larsson <who+github@cnackers.org>
@whooo whooo force-pushed the mypy-per-module branch 3 times, most recently from 3ca802d to f1efb36 Compare January 28, 2024 18:14
Ignore the encoding module for now, waiting for the tools support
to be removed.

Signed-off-by: Erik Larsson <who+github@cnackers.org>
@whooo whooo marked this pull request as ready for review January 28, 2024 18:44
@williamcroberts
Copy link
Member

@whooo what's the overarching point of these patches? It was lost on me.

@whooo
Copy link
Contributor Author

whooo commented Mar 25, 2024

@whooo what's the overarching point of these patches? It was lost on me.

To fix #362 and on the way clean up some bugs/bad type annotations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants