Vectorized hash grouping on one column

.github/gh_matrix_builder.py

@@ -78,7 +78,7 @@ def build_debug_config(overrides):
             "ignored_tests": default_ignored_tests,
             "name": "Debug",
             "os": "ubuntu-22.04",
-            "pg_extra_args": "--enable-debug --enable-cassert --with-llvm LLVM_CONFIG=llvm-config-14",
+            "pg_extra_args": "CFLAGS=-march=native --enable-debug --enable-cassert --with-llvm LLVM_CONFIG=llvm-config-14",
             "pg_extensions": "postgres_fdw test_decoding pageinspect pgstattuple",
             "pginstallcheck": True,
             "tsdb_build_args": "-DWARNINGS_AS_ERRORS=ON -DREQUIRE_ALL_TESTS=ON",

.github/workflows/linux-32bit-build-and-test.yaml

@@ -47,7 +47,9 @@ jobs:
         CC: clang-14
         CXX: clang++-14
         DEBIAN_FRONTEND: noninteractive
-        IGNORES: "append-* transparent_decompression-* transparent_decompress_chunk-* pg_dump telemetry bgw_db_scheduler* hypercore_vacuum"
+        # vectorized_aggregation has different output on i386 because int8 is by
+        # reference and currently it cannot be used for vectorized hash grouping.
+        IGNORES: "append-* transparent_decompression-* transparent_decompress_chunk-* pg_dump telemetry bgw_db_scheduler* hypercore_vacuum vectorized_aggregation"
         SKIPS: chunk_adaptive histogram_test-*
         EXTENSIONS: "postgres_fdw test_decoding pageinspect pgstattuple"
     strategy:

.unreleased/vectorized-grouping-one-fixed

@@ -0,0 +1 @@
+Implements: #7341 Vectorized aggregation with grouping by one fixed-size by-value compressed column (such as arithmetic types).

scripts/clang_format_all.sh

@@ -5,5 +5,5 @@ SCRIPT_DIR=$(cd "$(dirname $0)" || exit; pwd)
 BASE_DIR=$(dirname $SCRIPT_DIR)
 
 find ${BASE_DIR} \( -path "${BASE_DIR}/src/*" -or -path "${BASE_DIR}/test/*" -or -path "${BASE_DIR}/tsl/*" \) \
-    -and -not \( -path "*/.*" -or -path "*CMake*" \) \
+    -and -not \( -path "*/.*" -or -path "*CMake*" -or -path "${BASE_DIR}/tsl/src/import/*" \) \
     -and \( -name '*.c' -or -name '*.h' \) -print0 | xargs -0 ${SCRIPT_DIR}/clang_format_wrapper.sh -style=file -i

tsl/src/compression/arrow_c_data_interface.h

@@ -184,25 +184,62 @@ arrow_set_row_validity(uint64 *bitmap, size_t row_number, bool value)
 }
 
 /*
- * AND two optional arrow validity bitmaps into the given storage.
+ * Combine the validity bitmaps into the given storage.
  */
 static inline const uint64 *
 arrow_combine_validity(size_t num_words, uint64 *restrict storage, const uint64 *filter1,
-					   const uint64 *filter2)
+					   const uint64 *filter2, const uint64 *filter3)
 {
+	/*
+	 * Any and all of the filters can be null. For simplicity, move the non-null
+	 * filters to the front.
+	 */
+	const uint64 *tmp;
+#define SWAP(X, Y)                                                                                 \
+	tmp = (X);                                                                                     \
+	(X) = (Y);                                                                                     \
+	(Y) = tmp;
+
+	if (filter2 == NULL)
+	{
+		SWAP(filter2, filter3);
+	}
+
 	if (filter1 == NULL)
 	{
-		return filter2;
+		SWAP(filter1, filter2);
+
+		if (filter2 == NULL)
+		{
+			SWAP(filter2, filter3);
+		}
 	}
+#undef SWAP
+
+	Assert(filter2 == NULL || filter1 != NULL);
+	Assert(filter3 == NULL || filter2 != NULL);
 
 	if (filter2 == NULL)
 	{
+		/* Either have one non-null filter, or all of them are null. */
 		return filter1;
 	}
 
-	for (size_t i = 0; i < num_words; i++)
+	if (filter3 == NULL)
+	{
+		/* Have two non-null filters. */
+		for (size_t i = 0; i < num_words; i++)
+		{
+			storage[i] = filter1[i] & filter2[i];
+		}
+	}
+	else
 	{
-		storage[i] = filter1[i] & filter2[i];
+		/* Have three non-null filters. */
+		for (size_t i = 0; i < num_words; i++)
+		{
+			storage[i] = filter1[i] & filter2[i] & filter3[i];
+		}
 	}
 
 	return storage;

tsl/src/import/CMakeLists.txt

@@ -1,2 +1,2 @@
-set(SOURCES "")
-target_sources(${PROJECT_NAME} PRIVATE ${SOURCES})
+set(SOURCES ${CMAKE_CURRENT_SOURCE_DIR}/umash.c)
+target_sources(${TSL_LIBRARY_NAME} PRIVATE ${SOURCES})