Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorized hash grouping on one column #7316

Draft
wants to merge 192 commits into
base: main
Choose a base branch
from
Draft

Conversation

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 74.56140% with 377 lines in your changes missing coverage. Please review.

Project coverage is 81.84%. Comparing base (59f50f2) to head (5243d25).
Report is 622 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/import/umash.c 51.03% 250 Missing and 9 partials ⚠️
...odes/vector_agg/hashing/hash_strategy_serialized.c 82.01% 10 Missing and 24 partials ⚠️
...des/vector_agg/hashing/hash_strategy_single_text.c 82.03% 6 Missing and 17 partials ⚠️
tsl/src/nodes/vector_agg/grouping_policy_hash.c 90.37% 3 Missing and 15 partials ⚠️
tsl/src/import/ts_simplehash.h 89.43% 3 Missing and 12 partials ⚠️
.../src/nodes/vector_agg/hashing/hash_strategy_impl.c 85.93% 2 Missing and 7 partials ⚠️
tsl/src/nodes/vector_agg/plan.c 89.55% 3 Missing and 4 partials ⚠️
tsl/src/nodes/vector_agg/exec.c 91.52% 5 Missing ⚠️
tsl/src/compression/arrow_c_data_interface.h 75.00% 0 Missing and 3 partials ⚠️
...nodes/vector_agg/function/agg_many_vector_helper.c 95.00% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7316      +/-   ##
==========================================
+ Coverage   80.06%   81.84%   +1.77%     
==========================================
  Files         190      243      +53     
  Lines       37181    44585    +7404     
  Branches     9450    11130    +1680     
==========================================
+ Hits        29770    36489    +6719     
- Misses       2997     3679     +682     
- Partials     4414     4417       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We can inline the few lines of code required to create an array, instead
of calling the very generic `construct_array` function which shows up in
profiles.
It is enough to use the per-tuple context for them, now they end up in
the ExecutorState context which is incorrect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant