decrease earliest epoch value of query xml by 3 hours query XML #415
Conversation
|
please rebase |
elliVM
force-pushed
the
timestamp-epoch-minus-three-hours
branch
from
1551c09
to
bfeceed
Compare
|
Rebased |
|
I think you also need to change it for the produced XML and spark column to have an effect |
|
|
||
| if (tq.isStartTime()) { | ||
| startTime = tq.epoch(); | ||
| final TimeQualifierInterface timeQualifierInterface = new TimeQualifier( |
There was a problem hiding this comment.
I would rename TimeQualiferInterface to TimeQualifier, and the implementing class to TimeQualifierImpl
src/main/java/com/teragrep/pth10/ast/time/DecreasedEpochValue.java
Outdated
Show resolved
Hide resolved
yes, please add @elliVM |
| import java.util.Objects; | ||
|
|
||
| /** Decreases the amount from qualifier epoch value */ | ||
| public final class DecreasedEpochValue implements TimeQualifier { |
There was a problem hiding this comment.
please rename to DecreasedEpochXmlElementValue
|
|
||
| import java.util.Objects; | ||
|
|
||
| /** Decreases the amount from qualifier epoch value */ |
There was a problem hiding this comment.
please add comment that this is a temporary workaround for the pth_06 database schema
There was a problem hiding this comment.
added explanatory comment in javadoc
|
|
||
| @Override | ||
| public long epoch() { | ||
| return origin.epoch() - decreaseAmount; |
There was a problem hiding this comment.
only XML is to be decremented, the datasource code extracts proper timestamps from the data itself, only the search uses local timestamps incorrectly and that's controlled by the xml value.
There was a problem hiding this comment.
Change to only change value inside XML element, otherwise uses origins methods
…dd EqualsVerifier and contract test
|
Added EqualsVerifier library and contract test. |
Workaround to decrease earliest epoch value given to query XML by 3 hours to work with pth_06 that uses helsinki timezone.