Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YlmsFromSpEC to shape time dependent options #6114

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jun 25, 2024

Proposed changes

This is tangentially related to the PRs revamping the time dependent options for the Sphere and BCO domain creators.

This adds the ability to read the shape coefficients from a SpEC ID horizons dat file (not a dat file within an H5 file, but an actual dat file). If we are starting from SpEC ID (which we can do), then this is an important feature to have.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Depends on and includes #6109.

@knelli2 knelli2 added this to the BBH First Paper milestone Jun 25, 2024
@knelli2 knelli2 changed the title Dc time dep opts 3 Add YlmsFromSpEC to shape time dependent options Jun 25, 2024
@knelli2 knelli2 force-pushed the dc_time_dep_opts_3 branch 2 times, most recently from 6297c70 to dc63f9c Compare June 25, 2024 05:26
@knelli2 knelli2 added dependent Needs a different PR to be merged in first labels Jun 26, 2024
@knelli2 knelli2 removed the dependent Needs a different PR to be merged in first label Jul 9, 2024
@knelli2
Copy link
Contributor Author

knelli2 commented Jul 9, 2024

No longer dependent. Also added a commit that adds FromVolumeFile to the shape map options

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few small requests. Please squash immediately

@knelli2
Copy link
Contributor Author

knelli2 commented Sep 7, 2024

@nilsdeppe Squashed everything in. Thanks for the review

nilsdeppe
nilsdeppe previously approved these changes Sep 7, 2024
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this :D

@nilsdeppe
Copy link
Member

nilsdeppe commented Sep 7, 2024

Wat, clang-tidy now doesn't want you to use l because it looks like I? Nobody should use font that doesn't allow you to tell the difference when writing code. My vote is disable that warning.

Edit: the std::uniform_real_distribution<double> distribution(0.1, 2.0); to a const should be okay to do and squash in(?)

@knelli2
Copy link
Contributor Author

knelli2 commented Sep 7, 2024

Done!

@nilsdeppe nilsdeppe merged commit f23e75c into sxs-collaboration:develop Sep 7, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants