-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use full filename for svelte.compile #700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this produces stable builds on different machines, then it sounds like the best and simplest fix for me 👍
looks like the windows test is failing, ran it in my local windows 10 vm and it produced a development build with |
turns out something in our e2e tests sets A better default value for that would be |
fixes #699
There is a small chance that this creates a regression with build output still containing absolute paths in sourcemap sources, but in my tests with most recent svelte and vite versions, that is no longer the case.