Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use full filename for svelte.compile #700

Merged
merged 9 commits into from
Aug 6, 2023
Merged

fix: use full filename for svelte.compile #700

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
58ea256
fix: use full filename for svelte.compile to ensure errors work as ex…
dominikg Jul 28, 2023
0f44a87
chore: add changeset
dominikg Jul 28, 2023
62847df
fix: normalize snapshots for difference in windows compiler comment o…
dominikg Jul 28, 2023
bf9a2da
fix: try harder to normalize comment
dominikg Jul 28, 2023
f48264c
test: add testcase for hermetic build output
dominikg Jul 31, 2023
45a77ac
chore: log files that are leaking
dominikg Jul 31, 2023
ee10ae4
fix: yeah, that was dumb
dominikg Jul 31, 2023
dc5aa02
Merge branch 'main' into fix/absolute-paths-v2
dominikg Aug 5, 2023
cb6a6c9
fix: set NODE_ENV to prodution in build tests
dominikg Aug 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/grumpy-trains-do.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/vite-plugin-svelte': patch
---

fix links in error handling (console and vite overlay)
5 changes: 4 additions & 1 deletion packages/e2e-tests/import-queries/__tests__/import-queries.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,11 @@ import { VERSION } from 'svelte/compiler';
function normalizeSnapshot(result: string) {
// during dev, the import is rewritten but can vary on the v= hash. replace with stable short import
return result
.replace(
/\/\* .* generated by Svelte v\d\.\d+\.\d+(?:-[a-z]+\.\d+)? \*\//g,
'/* src/Dummy.svelte generated by Svelte vXXX */'
) // ensure generated svelte compiler comment is stable
.replace(/\.js\?v=[0-9a-f]{8}/g, '.js?v=XXX') // vite import analysis import rewrite version query
.replace(/generated by Svelte v\d\.\d+\.\d+(?:-[a-z]+\.\d+)?/g, 'generated by Svelte vXXX') // compiler version comment
.replace(/"total": *\d+\.\d+/g, '"total":0.123456789'); // svelte compile stats
}

Expand Down
2 changes: 1 addition & 1 deletion packages/vite-plugin-svelte/src/utils/compile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const _createCompileSvelte = (makeHot) => {
/** @type {import('../index.d.ts').CompileOptions} */
const compileOptions = {
...options.compilerOptions,
filename: normalizedFilename, // use normalized here to avoid bleeding absolute fs path
filename,
generate: ssr ? 'ssr' : 'dom'
};
if (isSvelte3) {
Expand Down