rcc enable #152
rcc enable #152
Conversation
|
Rebased |
|
I would say you need to decide what API you want. |
Thank you!
Not sure, to be honest. It's been a while since I actually used this HAL, or worked on the design of a STM32 HAL, or really thought about the design of STM32 HALs. It would be better if it was consistent, of course, but I don't know which of the options is best. Suggestions welcome! |
There was a problem hiding this comment.
Thank you, @burrbull, this looks great! I think that new infrastructure in RCC is a nice improvement.
You mentioned last time that you don't have F7 hardware. I assume this is still true, and this change hasn't been tested. Since this affects pretty much everything, I'd like to see some testing done before merging. As usual, it might take a while before I can get to it myself.
If anyone is reading this and wants to help out, please run some examples or your own code, and let us know how it works for you!
hannobraun
added
help wanted
|
As for the inconsistencies, I've opened #154. |
|
LGTM, tested with a STM32F767. |
| #[cfg(any(feature = "svd-f730", feature = "svd-f7x2", feature = "svd-f7x3",))] | ||
| bus! { | ||
| AES => (AHB2, aesen, aeslpen, aesrst), // 4 | ||
|
|
||
| SDMMC2 => (APB2, sdmmc2en, sdmmc2lpen, sdmmc2rst), // 7 |
There was a problem hiding this comment.
The SDMMC2 is not only available in svdf7x2 and svd-f7x3:
stm32f7xx/svd$ rg SDMMC2 -l --sort-files
STM32F7x2.svd
STM32F7x3.svd
STM32F7x7.svd
STM32F7x9.svdI did not take a look into svd-f730, svd-f745 and svd-f765.
There was a problem hiding this comment.
f765, f7x7 and f7x9 doesn't have sdmmc2en and sdmmc2rst fields in RCC.
This should be fixed in stm32-rs first
|
Thanks for testing, @systec-ms, and thanks again for the pull request, @burrbull! |
No description provided.