Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable changelog workflows #542

Merged
merged 2 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions .github/workflows/update_dbt_marts_schema_changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,28 +45,28 @@ jobs:
output=$(. scripts/update_dbt_marts_schema_changelog.sh)
echo "$output" > changelog/dbt_marts.md

- name: Commit changes
id: commit_changes
run: |
git add changelog/dbt_marts.md
if git commit -m "Update changelog for DBT marts"; then
echo "Changes committed."
echo "changes_committed=true" >> $GITHUB_OUTPUT
else
echo "No changes to commit."
echo "changes_committed=false" >> $GITHUB_OUTPUT
fi
# - name: Commit changes
# id: commit_changes
# run: |
# git add changelog/dbt_marts.md
# if git commit -m "Update changelog for DBT marts"; then
# echo "Changes committed."
# echo "changes_committed=true" >> $GITHUB_OUTPUT
# else
# echo "No changes to commit."
# echo "changes_committed=false" >> $GITHUB_OUTPUT
# fi

- name: Push branch
if: steps.commit_changes.outputs.changes_committed == 'true'
run: |
git push origin ${{ steps.create_branch.outputs.branch }}
# - name: Push branch
# if: steps.commit_changes.outputs.changes_committed == 'true'
# run: |
# git push origin ${{ steps.create_branch.outputs.branch }}

- name: Create Pull Request
if: steps.commit_changes.outputs.changes_committed == 'true'
run: |
gh pr create -B master -H ${{ steps.create_branch.outputs.branch }} \
--title 'Update schema changelog for DBT marts' \
--body 'This is an autogenerated PR to update schema changelog for marts.'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# - name: Create Pull Request
# if: steps.commit_changes.outputs.changes_committed == 'true'
# run: |
# gh pr create -B master -H ${{ steps.create_branch.outputs.branch }} \
# --title 'Update schema changelog for DBT marts' \
# --body 'This is an autogenerated PR to update schema changelog for marts.'
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
22 changes: 11 additions & 11 deletions .github/workflows/update_source_data_schema_changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@ jobs:
rm -rf $OLD_SCHEMAS_DIR
rm -rf repo_master_copy

- name: Commit and Push Changes
run: |
git config --local user.email "action@github.com"
git config --local user.name "GitHub Action"
git add changelog/source_data.md
if git commit -m "Update changelog for Source data"; then
echo "Changes committed."
git push
else
echo "No changes to commit."
fi
# - name: Commit and Push Changes
# run: |
# git config --local user.email "action@github.com"
# git config --local user.name "GitHub Action"
# git add changelog/source_data.md
# if git commit -m "Update changelog for Source data"; then
# echo "Changes committed."
# git push
# else
# echo "No changes to commit."
# fi
9 changes: 8 additions & 1 deletion dags/dbt_data_quality_alerts_dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,14 @@

# Trigger elementary
elementary_alerts = elementary_task(
dag, "dbt_data_quality", "monitor", resource_cfg="dbt"
dag,
"dbt_data_quality",
"monitor",
resource_cfg="dbt",
cmd_args=[
"--profiles-dir",
".",
],
Comment on lines +37 to +40
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading elementary broke this one, therefore this is a bug fix

)

elementary_alerts
Loading