Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable changelog workflows #542

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Disable changelog workflows #542

merged 2 commits into from
Nov 14, 2024

Conversation

amishas157
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository.

What

This PR disables GH workflows added to update changelog. This is because we are currently limited by security team to have CI runs enabled on commit made by GH bot.

I will work on it in the coming weeks, but to keep our repo clean, disable this workflows for now.

This PR also adds CMD args in elementary task so as to keep up with version upgrade happened in previous PR

Why

[TODO: Why this change is being made. Include any context required to understand the why.]

Known limitations

[TODO or N/A]

@amishas157 amishas157 marked this pull request as ready for review November 13, 2024 16:19
@amishas157 amishas157 requested a review from a team as a code owner November 13, 2024 16:19
Comment on lines +37 to +40
cmd_args=[
"--profiles-dir",
".",
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading elementary broke this one, therefore this is a bug fix

@amishas157 amishas157 merged commit 00a6e92 into master Nov 14, 2024
3 checks passed
@sydneynotthecity sydneynotthecity deleted the patch/remove-gh-workflows branch November 21, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants