Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages: Collect unknown fields in message type #39

Open
wants to merge 2 commits into
base: feature/13-add-data-types-for-messages
Choose a base branch
from

Commits on Feb 23, 2024

  1. messages: Collect unknown fields in message type

    In the initial implementation, we had a config option to determine
    whether unknown fields should return an error.  Based on the discussion
    in [0], I think it is better to just collect unexpected fields in the
    message type and let the user decide how to handle them.
    
    [0] stadelmanma#13
    robinkrahl committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    82d4d65 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. messages: Use map instead of vec for unknown fields

    The name for unknown fields is just unknown_field_n, so it does not
    provide any additional value.  Using a map instead of a vec makes it
    easier to access the data.
    robinkrahl committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    10dfee9 View commit details
    Browse the repository at this point in the history