messages: Collect unknown fields in message type #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the initial implementation, we had a config option to determine whether unknown fields should return an error. Based on the discussion in [0], I think it is better to just collect unexpected fields in the message type and let the user decide how to handle them. [0] stadelmanma#13
robinkrahl
force-pushed
the
unknown-fields
branch
from
9f57005
to
82d4d65
Compare
robinkrahl
commented
Feb 24, 2024
The name for unknown fields is just unknown_field_n, so it does not provide any additional value. Using a map instead of a vec makes it easier to access the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the initial implementation, we had a config option to determine whether unknown fields should return an error. Based on the discussion in [0], I think it is better to just collect unexpected fields in the message type and let the user decide how to handle them.
[0] #13