Disincentivizing the use of all caps in post titles #590

SatsAllDay · 2023-10-27T15:11:10Z

Closes #584

This PR updates the fees required to make a post that has more than 12 uppercase letters in its title, to help disincentivize using all-caps in users' headlines.

The basic approach is as follows:

When making a new post, calculate the posting fee as normal. If the title exceeds 12 uppercase characters, multiply that fee by 100. Any boost gets added after the multiplying happens.
The create_item sql function is updated to support this multiplier as a parameter. Passing a multiplier of 1 essentially means no fee change (identity fn).
If the user does pay this multiplied fee, a new boolean flag is set on the item to track this. This flag is used to accommodate the edit case, described next.
Prior to this change, when editing a post, there are no fees incurred. With these changes, we check the title of the post on edit to see if it exceeds 12 uppercase characters. We then check the new boolean flag on the item to see if this multiplier fee had been paid already. If it's already been paid on the item, no additional fee is charged. If it hasn't been paid, we apply a fee multiplier of 99 (100 less the one unit already paid when the post was created).
The update_item sql function is updated to support arbitrary additional fees to charge the user, and the fee calculation is handled in the item resolver JS function. This should help keep the sql function a little more static and push the logic to the resolver layer which is easier to change.

Other tidbits:

Create and Edit fee receipts are also updated to reflect this change.
If the original item was a freebie, and it is then edited to exceed 12 uppercase characters in the title, that edit will cost 1000 sats (100 * 10), making it no longer a freebie.
~~3. I realize these changes will likely conflict with Image uploads #576. Feel free to merge that PR first and I can update this PR to accommodate accordingly.~~ Yep, lots of conflicts :)

create_item diff:

diff --git a/create_item.old.sql b/create_item.new.sql
diff --git a/create_item.old.sql b/create_item.new.sql
index 9342daf..942ef7d 100644
--- a/create_item.old.sql
+++ b/create_item.new.sql
@@ -1,5 +1,5 @@
 CREATE OR REPLACE FUNCTION create_item(
-    jitem JSONB, forward JSONB, poll_options JSONB, spam_within INTERVAL, upload_ids INTEGER[])
+    jitem JSONB, forward JSONB, poll_options JSONB, spam_within INTERVAL, upload_ids INTEGER[], upper_title_fee_mult INTEGER)
 RETURNS "Item"
 LANGUAGE plpgsql
 AS $$
@@ -32,6 +32,9 @@ BEGIN
         cost_msats := cost_msats * POWER(10, item_spam(item."parentId", item."userId", spam_within));
     END IF;
 
+    -- Uppercase title fee multiplier (before image fees or after?)
+    cost_msats := cost_msats * upper_title_fee_mult;
+
     -- add image fees
     IF upload_ids IS NOT NULL THEN
         cost_msats := cost_msats + (SELECT "nUnpaid" * "imageFeeMsats" FROM image_fees_info(item."userId", upload_ids));

update_item diff:

diff --git a/update_item.old.sql b/update_item.new.sql
index b053159..2d8f937 100644
--- a/update_item.old.sql
+++ b/update_item.new.sql
@@ -1,5 +1,5 @@
 CREATE OR REPLACE FUNCTION update_item(
-    jitem JSONB, forward JSONB, poll_options JSONB, upload_ids INTEGER[])
+    jitem JSONB, forward JSONB, poll_options JSONB, upload_ids INTEGER[], additional_fee_msats BIGINT)
 RETURNS "Item"
 LANGUAGE plpgsql
 AS $$
@@ -27,6 +27,9 @@ BEGIN
             SELECT item.id, * FROM UNNEST(upload_ids) ON CONFLICT DO NOTHING;
     END IF;
 
+    -- add addl fees
+    cost_msats := cost_msats + additional_fee_msats
+
     IF cost_msats > 0 AND cost_msats > user_msats THEN
         RAISE EXCEPTION 'SN_INSUFFICIENT_FUNDS';
     ELSE

.gitignore

SatsAllDay · 2023-10-30T16:10:19Z

components/fee-button.js

  return (
    <Table className={styles.receipt} borderless size='sm'>
      <tbody>
        <tr>
          <td>{numWithUnits(baseFee, { abbreviate: false })}</td>
          <td align='right' className='font-weight-light'>{parentId ? 'reply' : 'post'} fee</td>
        </tr>
-        {hasImgLink &&


Removed hasImgLink dead code, based on earlier discussion

SatsAllDay · 2023-10-30T16:10:37Z

components/fee-button.js

+            <td className='font-weight-light' align='right'>{numWithUnits(repetition, { abbreviate: false, unitPlural: parentId ? 'repeat or self replies' : 'posts', unitSingular: parentId ? 'repeat or self reply' : 'post' })} in 10m</td>
+          </tr>}


I couldn't help myself to fix the singular/plural of this line item.

SatsAllDay · 2023-10-30T16:11:12Z

components/fee-button.js

          <>
            <tr>
              <td>{numWithUnits(paidSats, { abbreviate: false })}</td>
              <td align='right' className='font-weight-light'>{parentId ? 'reply' : 'post'} fee</td>
            </tr>
            <tr>
-              <td>x 10</td>
-              <td align='right' className='font-weight-light'>image/link fee</td>
+              <td>{paidSats === 0 ? '+' : 'x'} {numWithUnits(addUppercaseTitleMult, { abbreviate: false, format: true, unitSingular: '', unitPlural: '' })}</td>


This line item is a little complex due to handling editing freebie posts.

SatsAllDay · 2023-10-30T16:11:44Z

components/link-form.js

@@ -145,10 +145,6 @@ export function LinkForm ({ item, sub, editThreshold, children }) {
              variables: { title: e.target.value }
            })
          }
-          if (e.target.value === e.target.value.toUpperCase()) {


Remove existing all-caps treatment

SatsAllDay · 2023-10-30T16:12:09Z

docker-compose.yml

@@ -39,7 +39,7 @@ services:
      db:
        condition: service_started
      app:
-        condition: service_healthy
+        condition: service_started


I found my worker service always had to be started manually locally, so I made this change to fix that.

I think this was originally implemented because if app wasn't running worker occasionally crashed on start becauese the migrations weren't applied yet. idk though. If it works for you maybe that's not true.

With the new nextjs startup of the web server is slower. I wonder if this check timesout before going healthy.

It could have been a false positive for me if I had already applied migrations locally, then. I just noticed that my worker never started on it's own, I always had to go start it manually, so I figured this was the cause. ¯\_(ツ)_/¯

SatsAllDay · 2023-10-30T16:12:35Z

prisma/migrations/20231026204718_uppercase_title/migration.sql

@@ -0,0 +1,191 @@
+-- AlterTable


See the diff in the PR description to better understand the actual changes to these functions

ekzyis · 2023-11-13T03:50:23Z

This branch has conflicts that must be resolved
Use the web editor or the to resolve conflicts.
Conflicting files
api/resolvers/item.js
components/bounty-form.js
components/discussion-form.js
components/fee-button.js
components/fee-button.module.css
components/link-form.js
components/poll-form.js
pages/[name]/index.js

Rebase required 👀

SatsAllDay · 2023-11-13T09:36:19Z

I'll try to rebase it later today

SatsAllDay · 2023-11-18T18:27:39Z

FYI I am working on rebasing this now...

handle uppercase addl fees for edit item Rename migration now that the rogue migration has been renamed various fee button and receipt cleanup set upperTitleFeePaid in JS instead of sql add patch files at root to gitignore for utility purposes consolidate some comparison logic into a utility various minor code cleanup make receipts wider to accommodate longer line items fix freebie edit charge to use msats instead of sats update edit receipt to make more sense for freebie posts with uppercase title multiplier update docker-compose so worker actually starts automatically in local dev

…anges

SatsAllDay · 2023-11-18T22:01:59Z

I've got most of it rebased, I am working on the fee button UI updates next/last.

Edit: done!

don't show empty boost line item in receipt

…uppercase chars

…edit

…ebie

huumn · 2023-11-19T22:05:13Z

The work here is solid. I'll send you sats for this upfront, but until I have a bit more PR time I'm going to drop this into draft because

fees always make me anxious
I have some other content-based fee plans that I'd like to consider alongside this to see if it can be made a little more generic
- we have multiple sources of variable fees on items
  - boost
  - images
  - repeat posts
  - all caps
  - ... potentially other things in the future
  - each one of these on their own is a source of confusion and in aggregate they're probably even more confusing
as we discussed in Handle nym similarity #588, I struggle with fees vs just outright preventing bad behavior

I know it's a little disappointing but I'll come back to this and #588 after territories ship and can afford to give it a good think.

SatsAllDay · 2023-11-20T01:13:18Z

No worries dude! That sounds good. As always, I appreciate the transparency.

SatsAllDay force-pushed the 584-disincentivize-all-caps branch from a308b70 to 8cf806e Compare October 29, 2023 15:00

SatsAllDay marked this pull request as ready for review October 30, 2023 16:08

SatsAllDay changed the title ~~WIP: Disincentivizing the use of all caps in post titles~~ Disincentivizing the use of all caps in post titles Oct 30, 2023

SatsAllDay commented Oct 30, 2023

View reviewed changes

SatsAllDay force-pushed the 584-disincentivize-all-caps branch from 2576ec4 to d224d6b Compare October 30, 2023 19:53

SatsAllDay force-pushed the 584-disincentivize-all-caps branch 2 times, most recently from 3fd692b to 82f869c Compare November 17, 2023 00:46

SatsAllDay force-pushed the 584-disincentivize-all-caps branch from 82f869c to f9f9c75 Compare November 18, 2023 18:30

SatsAllDay marked this pull request as draft November 18, 2023 18:30

SatsAllDay added 3 commits November 18, 2023 13:32

rename migration to put it at the end of the current migrations

acf871d

update migration to incorporate latest create_item and update_item ch…

08a0443

…anges

fix migration semicolon

af084c9

SatsAllDay added 7 commits November 18, 2023 19:44

Reflect uppercase chars multiplier in fee button UI

6baea7a

format boost price in receipt

527064d

don't show empty boost line item in receipt

handle the case where the post was a freebie but now it has too many …

9c3b4a8

…uppercase chars

correct receipt items for applying an uppercase fee multiplier in an …

4ff584b

…edit

remove unused prop, revert css changes

148a1fd

factor in sub base cost when calculating addl fees when editing a fre…

55f4c85

…ebie

don't include image fees in uppercase multiplier

38b66a1

SatsAllDay marked this pull request as ready for review November 19, 2023 02:13

Merge branch 'master' into 584-disincentivize-all-caps

a118b3b

huumn marked this pull request as draft November 19, 2023 22:05

ekzyis mentioned this pull request Dec 30, 2023

Remove ineffective guard against all caps #723

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disincentivizing the use of all caps in post titles #590

Disincentivizing the use of all caps in post titles #590

SatsAllDay commented Oct 27, 2023 •

edited

Loading

SatsAllDay Oct 30, 2023

SatsAllDay Oct 30, 2023

SatsAllDay Oct 30, 2023

SatsAllDay Oct 30, 2023

SatsAllDay Oct 30, 2023

huumn Nov 1, 2023 •

edited

Loading

SatsAllDay Nov 1, 2023

SatsAllDay Oct 30, 2023

ekzyis commented Nov 13, 2023

SatsAllDay commented Nov 13, 2023

SatsAllDay commented Nov 18, 2023

SatsAllDay commented Nov 18, 2023 •

edited

Loading

huumn commented Nov 19, 2023

SatsAllDay commented Nov 20, 2023

		<td className='font-weight-light' align='right'>{numWithUnits(repetition, { abbreviate: false, unitPlural: parentId ? 'repeat or self replies' : 'posts', unitSingular: parentId ? 'repeat or self reply' : 'post' })} in 10m</td>
		</tr>}

Disincentivizing the use of all caps in post titles #590

Are you sure you want to change the base?

Disincentivizing the use of all caps in post titles #590

Conversation

SatsAllDay commented Oct 27, 2023 • edited Loading

SatsAllDay Oct 30, 2023

Choose a reason for hiding this comment

SatsAllDay Oct 30, 2023

Choose a reason for hiding this comment

SatsAllDay Oct 30, 2023

Choose a reason for hiding this comment

SatsAllDay Oct 30, 2023

Choose a reason for hiding this comment

SatsAllDay Oct 30, 2023

Choose a reason for hiding this comment

huumn Nov 1, 2023 • edited Loading

Choose a reason for hiding this comment

SatsAllDay Nov 1, 2023

Choose a reason for hiding this comment

SatsAllDay Oct 30, 2023

Choose a reason for hiding this comment

ekzyis commented Nov 13, 2023

SatsAllDay commented Nov 13, 2023

SatsAllDay commented Nov 18, 2023

SatsAllDay commented Nov 18, 2023 • edited Loading

huumn commented Nov 19, 2023

SatsAllDay commented Nov 20, 2023

SatsAllDay commented Oct 27, 2023 •

edited

Loading

huumn Nov 1, 2023 •

edited

Loading

SatsAllDay commented Nov 18, 2023 •

edited

Loading