Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ineffective guard against all caps #723

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Dec 30, 2023

With this PR, I am suggesting to remove the existing guard against all caps titles for the following reasons:

  • it's ineffective since it only makes the second letter lower case
  • there are ways to not make it trigger and thus still be able to post links with all caps
  • it's unexpected and thus confusing
  • there are legitimate use cases for using all caps in the first few letters. example: acronyms
  • it only applied to link posts (inconsistent UX)

related to #584, #590

@ekzyis ekzyis added the ux label Dec 30, 2023
@ekzyis
Copy link
Member Author

ekzyis commented Dec 30, 2023

And can I rename the label "confusing ux" to just "ux"? Then we can use this label more effectively since not every UX ticket will be about confusing UX.

This "confusing UX" label is also confusing UX, lol

@huumn
Copy link
Member

huumn commented Dec 30, 2023

And can I rename the label "confusing ux" to just "ux"? Then we can use this label more effectively since not every UX ticket will be about confusing UX.

Go for it

@huumn huumn merged commit c23799b into stackernews:master Dec 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants