Only fetch logs when we need them #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobl
reviewed
Nov 22, 2024
ekzyis
force-pushed
the
fix-anon-wallet-logs-typeerror
branch
from
3eba346
to
b1b09df
Compare
This was referenced Nov 23, 2024
Draft
huumn
reviewed
Nov 23, 2024
ekzyis
force-pushed
the
fix-anon-wallet-logs-typeerror
branch
from
f865488
to
74581a2
Compare
This makes sure that we wait for the pending poll to finish before we poll again. This prevents running multiple polls at the same time on slow connections. I noticed we don't need to queue a new poll ourselves since a poll updates effect dependencies so we will cleanup and run the effect again anyway.
ekzyis
force-pushed
the
fix-anon-wallet-logs-typeerror
branch
from
74581a2
to
a66c7bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1635 by never fetching wallet logs as anon.
Additionally, only fetch wallet logs on the pages where we actually need them.
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7. Logs aren't fetched as anon. Logs are only fetched on pages that start with /settings/wallets or on the /wallet/logs page.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no