More wallet hooks: useWalletStatus & useWalletSupport #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzyis
force-pushed
the
more-wallet-hooks
branch
from
cf5005a
to
3c41db9
Compare
huumn
reviewed
Nov 24, 2024
|
|
||
| export default function WalletCard ({ wallet, draggable, onDragStart, onDragEnter, onDragEnd, onTouchStart, sourceIndex, targetIndex, index }) { | ||
| const image = useWalletImage(wallet) | ||
| const status = useWalletStatus(wallet) | ||
| const support = useWalletSupport(wallet) |
There was a problem hiding this comment.
Oh boy that's like a breathe of fresh air.
|
Keeping this as a draft until #1638 is merged and I rebased this again on master |
ekzyis
force-pushed
the
more-wallet-hooks
branch
from
3c41db9
to
d036743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed this
-- #1643 (comment)
also applies to what I did in #1559. This PR removes that code from
useWalletsand moves it into their own wallet hooks.Based on #1638, #1640
Additional Context
useWalletSupportis a bit of a ridiculous "hook" but I think it's indeed better to have it separated so we can use it only where we need it (which is only inside theWalletCardcomponent).Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7. Wallet cards still show correct status and support.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no