Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH PHP 8.4 support #11480

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Nov 28, 2024

Issue silverstripe/.github#331

Do not squash merge, as there are multiple commits

@emteknetnz emteknetnz changed the title API Explicity mark nullable paramters for PHP 8.4 API Explicity mark nullable parameters for PHP 8.4 Nov 28, 2024
@emteknetnz emteknetnz force-pushed the pulls/6/php84 branch 2 times, most recently from c8fa66f to 814f0ed Compare December 2, 2024 07:44
@emteknetnz emteknetnz changed the title API Explicity mark nullable parameters for PHP 8.4 ENH PHP 8.4 support Dec 2, 2024
@emteknetnz emteknetnz marked this pull request as ready for review December 2, 2024 20:37
@GuySartorelli
Copy link
Member

@emteknetnz There's still Ci failures on a PHP 8.4 run here

@emteknetnz emteknetnz force-pushed the pulls/6/php84 branch 3 times, most recently from cfc0127 to d0ec502 Compare December 3, 2024 01:11
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 5b02fe2 into silverstripe:6 Dec 3, 2024
11 of 12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/php84 branch December 3, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants