PHP 8.4 support (after 21 November)

[GuySartorelli]

PHP 8.4 releases on 21 November.

The major release policy states

At launch, a Silverstripe CMS major release supports all PHP versions in full support.

And
> Following the initial launch of a Silverstripe CMS major release, the development team aims to add forward compatibility for the next PHP release. e.g: Silverstripe CMS 5 at launch will support PHP 8.1 and PHP 8.2. CMS 5 should receive official support for an eventual PHP 8.3 in early 2024.

Acceptance criteria

• All CMS 6 supported modules are compatible with PHP 8.4 with no deprecation warnings
• All CMS 5.4 supported modules are compatible with PHP 8.4 with no deprecation warnings

CI PRs

• ENH PHP 8.4 for CMS 6 supported-modules#47
• MNT Update unit tests for PHP 8.4 gha-generate-matrix#113
• ENH Use MySQL 8.4 for the PHP 8.4 endtoend job in CMS 6 gha-generate-matrix#114

After merging CI PRs, re-trigger with force push PRs below to get PHP 8.4 jobs in matrix

Kitchen sink CI

• https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/12112788566

PRs

• API Explicity mark nullable parameters for PHP 8.4 silverstripe-elemental#1285
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-admin#1863
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-asset-admin#1518
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-assets#662
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-blog#797
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-cms#3032
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-framework#11480
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-graphql#614
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-hybridsessions#115
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-linkfield#353
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-lumberjack#178
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-realme#171
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-session-manager#227
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-siteconfig#182
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-subsites#617
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-userforms#1352
• API Explicity mark nullable parameters for PHP 8.4 vendor-plugin#87
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-versioned#483
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-versioned-admin#374
• API Explicity mark nullable parameters for PHP 8.4 symbiote/silverstripe-advancedworkflow#563
• API Explicity mark nullable parameters for PHP 8.4 symbiote/silverstripe-gridfieldextensions#423
• API Explicity mark nullable parameters for PHP 8.4 symbiote/silverstripe-queuedjobs#453
• API Explicity mark nullable parameters for PHP 8.4 tractorcow-farm/silverstripe-fluent#911
• API Explicity mark nullable parameters for PHP 8.4 closure#4
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-webauthn-authenticator#202
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-behat-extension#291
• API Explicity mark nullable parameters for PHP 8.4 silverstripe-event-dispatcher#30
• API Explicity mark nullable parameters for PHP 8.4 MinkFacebookWebDriver#29

[GuySartorelli]

@emteknetnz We don't add PHP 8.4 support to CMS 5. The quote you added is about adding PHP 8.3 support to CMS 5.
Specifically:

the development team aims to add forward compatibility for the next PHP release

Similarly we'll add 8.5 to CMS 6 when it releases, and not 8.6 to CMS 6.

Similarly for CMS 4 we added PHP 8.1 support but not 8.2 or 8.3

[emteknetnz]

Have updated description to remove from CMS 5

[emteknetnz]

The following .php-cs-fixer.php script was used to make changes to nullable parameters using php-cs-fixer and then running vendor/bin/php-cs-fixer fix

<?php

include 'vendor/autoload.php';

use PhpCsFixer\Config;
use PhpCsFixer\Finder;

# https://github.com/silverstripe/supported-modules/blob/44e741b156b6ab8aeed2db6d1093dc5c48a06cc8/repositories.json
$json = json_decode(file_get_contents('repositories.json'), true);

$modules = [];

foreach ($json["supportedModules"] as $module) {
    [$vendor, $dir] = explode('/', $module["packagist"]);
    $supported = isset($module["majorVersionMapping"]["6"]);
    $modules[$vendor] ??= [];
    $modules[$vendor][$dir] = $supported;
}

$vendors = [
    'silverstripe',
    'symbiote',
    'tractorcow',
    'dnadesign',
    'colymba',
];

$in = [];
foreach ($vendors as $vendor) {
    $dirs = scandir(__DIR__ . '/vendor/' . $vendor);
    foreach ($dirs as $dir) {
        if (in_array($dir, ['.', '..'])) {
            continue;
        }
        $path = __DIR__ . '/vendor/' . $vendor . '/' . $dir;
        if (str_contains($path, 'recipe-kitchen-sink')) {
            continue;
        }
        // skip explicitly unsupported modules, excluding a few exceptions
        if (isset($modules[$vendor][$dir]) && !$modules[$vendor][$dir]) {
            if (!str_contains($path, 'silverstripe/blog')
                && !str_contains($path, 'silverstripe/subsites')
                && !str_contains($path, 'silverstripe/crontask')
                && !str_contains($path, 'silverstripe/webauthn-authenticator')
            ) {
                continue;
            }
        } 
        $in[] = $path;
    }
}

$finder = Finder::create()
    ->in($in)
    ->name('*.php');

return (new Config())
    ->setFinder($finder)
    ->setRules([
        'nullable_type_declaration_for_default_null_value' => true,
    ]);