API Explicity mark nullable parameters for PHP 8.4 #1518
+19
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
emteknetnz
force-pushed
the
pulls/3/php84
branch
from
91a8bed
to
7554abd
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/3/php84
branch
2 times, most recently
from
e5735f9
to
1d96bab
Compare
emteknetnz
force-pushed
the
pulls/3/php84
branch
from
1d96bab
to
7cd4d4d
Compare
emteknetnz
force-pushed
the
pulls/3/php84
branch
from
7cd4d4d
to
715019f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#331
Do not squash merge, as has a second commit to fix optional parameters