Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export ffi crate and foreign-types traits #2021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhouck
Copy link
Contributor

@dhouck dhouck commented Aug 26, 2023

Closes #2020

I also re-exported the ffi crate, for the same reason; I can remove that part if it isnʼt wanted, but it seems reasonable to me for the same reason I mention there.

At a quick glance I couldnʼt find other things that obviously looked like they should be re-exported.

@dhouck
Copy link
Contributor Author

dhouck commented Aug 26, 2023

I just confirmed that this PR does not touch the file Clippy is complaining about, or indeed anything in openssl-sys. I do not know why this PR fails that check when my previous PR passed it and the relevant files have not been changed since that previous PR was made.

The rustfmt check is entirely on me, though; fixing that now.

@dhouck
Copy link
Contributor Author

dhouck commented Aug 26, 2023

I cannot figure out why clippy started complaining now. GitHub updated the test runner images, but the new one has the same version of all rust tools and of the openssl libraries. I can see the issue itʼs complaining about has existed for two years. I cannot get Clippy to complain on my machine, although that might just be that I should have been in bed hours ago.

In the morning, Iʼll make another PR to fix the problem Clippy is complaining about, then hopefully once thatʼs merged I can rebase this one and itʼll pass all checks. But it still bugs me that something changed and I have no clue what.

@romen
Copy link

romen commented Mar 14, 2024

@sfackler what is the status of this PR? Are there plans to merge it in the foreseeable future or is something holding it back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using openssl with openssl-sys
2 participants