Fix auto-fixable Clippy warnings #2024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never mind; you got there first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Creating this, as I said I would in #2021)
This does not fix all the new Clippy warnings, assuming the set I see after I ran
rustupthis morning is the same set GitHub sees. There are four warnings internal to thebitflags!macro which Iʼm not sure how to fix. Clippy doesnʼt seem to have a good option to disable lints inside a macro, and disabling it globally seems excessive. Bumping thebitflagscrate to the latest version makes it stop compiling correctly; bumping it to the latest 1.x version compiles and passes all tests but does not get rid of the warning.Thoughts? Or should this be merged as-is and the rest handled separately by someone who knows this codebase better?