Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Hyper 1.x #1090

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

urkle
Copy link
Contributor

@urkle urkle commented Jan 31, 2024

Phase 1: ( https://hyper.rs/guides/1/upgrading/ )

  • enable backport and deprecated features on hyper
  • update code from deprecated recommendations

Phase 2: update to hyper 1.x

update crates

  • hyper 1.1
  • http 1.0
  • multer 3.0
  • headers 0.4.0

add crates

  • hyper-util 0.1.2
  • http-body 1
  • http-body-util 0.1.0

Issues so far in phase 2

  • Incoming::empty() is private
  • AsyncRead not implemented for hyper::upgrade::Upgraded
  • Incoming::wrap_stream() removed!
  • make_service_fn removed
  • hyper::Server removed (along w/ builder)
  • no hyper::server::conn::AddrStream
  • no hyper::server::conn::AddrIncoming
  • switch Client to hyper_util?

- enable backport and deprecated features on hyper
- update code from deprecated recommendations
@urkle urkle mentioned this pull request Jan 31, 2024
flokli added a commit to flokli/bigtable_rs that referenced this pull request Jul 30, 2024
This requires updating prost crates to 0.13.x, tonic to 0.12.x and
prost-wkt-* to 0.6.*.

Only the examples still pull in http 0.x, due to
seanmonstar/warp#1090, but that shouldn't affect
consumers of bigtable_rs.
flokli added a commit to flokli/bigtable_rs that referenced this pull request Aug 24, 2024
This requires updating prost crates to 0.13.x, tonic to 0.12.x and
prost-wkt-* to 0.6.*.

Only the examples still pull in http 0.x, due to
seanmonstar/warp#1090, but that shouldn't affect
consumers of bigtable_rs.

Co-Authored-By: Connor Brewster <cbrewster@hey.com>
flokli added a commit to flokli/bigtable_rs that referenced this pull request Aug 27, 2024
This requires updating prost crates to 0.13.x, tonic to 0.12.x and
prost-wkt-* to 0.6.*.

Only the examples still pull in http 0.x, due to
seanmonstar/warp#1090, but that shouldn't affect
consumers of bigtable_rs.

Co-Authored-By: Connor Brewster <cbrewster@hey.com>
flokli added a commit to flokli/bigtable_rs that referenced this pull request Sep 1, 2024
This requires updating prost crates to 0.13.x, tonic to 0.12.x and
prost-wkt-* to 0.6.*.

Only the examples still pull in http 0.x, due to
seanmonstar/warp#1090, but that shouldn't affect
consumers of bigtable_rs.

Co-Authored-By: Connor Brewster <cbrewster@hey.com>
flokli added a commit to flokli/bigtable_rs that referenced this pull request Sep 1, 2024
This requires updating prost crates to 0.13.x, tonic to 0.12.x and
prost-wkt-* to 0.6.*.

Only the examples still pull in http 0.x, due to
seanmonstar/warp#1090, but that shouldn't affect
consumers of bigtable_rs.

Co-Authored-By: Connor Brewster <cbrewster@hey.com>
liufuyang pushed a commit to liufuyang/bigtable_rs that referenced this pull request Sep 3, 2024
This requires updating prost crates to 0.13.x, tonic to 0.12.x and
prost-wkt-* to 0.6.*.

Only the examples still pull in http 0.x, due to
seanmonstar/warp#1090, but that shouldn't affect
consumers of bigtable_rs.

Co-Authored-By: Connor Brewster <cbrewster@hey.com>
liufuyang pushed a commit to liufuyang/bigtable_rs that referenced this pull request Sep 3, 2024
This requires updating prost crates to 0.13.x, tonic to 0.12.x and
prost-wkt-* to 0.6.*.

Only the examples still pull in http 0.x, due to
seanmonstar/warp#1090, but that shouldn't affect
consumers of bigtable_rs.

Co-Authored-By: Connor Brewster <cbrewster@hey.com>
liufuyang pushed a commit to liufuyang/bigtable_rs that referenced this pull request Sep 3, 2024
This requires updating prost crates to 0.13.x, tonic to 0.12.x and
prost-wkt-* to 0.6.*.

Only the examples still pull in http 0.x, due to
seanmonstar/warp#1090, but that shouldn't affect
consumers of bigtable_rs.

Co-Authored-By: Connor Brewster <cbrewster@hey.com>
liufuyang pushed a commit to liufuyang/bigtable_rs that referenced this pull request Sep 9, 2024
This requires updating prost crates to 0.13.x, tonic to 0.12.x and
prost-wkt-* to 0.6.*.

Only the examples still pull in http 0.x, due to
seanmonstar/warp#1090, but that shouldn't affect
consumers of bigtable_rs.

Co-Authored-By: Connor Brewster <cbrewster@hey.com>
liufuyang added a commit to liufuyang/bigtable_rs that referenced this pull request Sep 9, 2024
* chore: update to http 1.x crates

This requires updating prost crates to 0.13.x, tonic to 0.12.x and
prost-wkt-* to 0.6.*.

Only the examples still pull in http 0.x, due to
seanmonstar/warp#1090, but that shouldn't affect
consumers of bigtable_rs.

Co-Authored-By: Connor Brewster <cbrewster@hey.com>

* chore: run cargo fmt in build.rs

* chore: commit in missing diffs from the origianl PR 86

* chore: add conditions in build.rs

* chore: update CI to setup BUILD_BIGTABLE_RS_GOOGLE_PROTO=true for cargo build

---------

Co-authored-by: Florian Klink <flokli@flokli.de>
Co-authored-by: Connor Brewster <cbrewster@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant