-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: upgrade to http=1 #502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BatmanAoD
force-pushed
the
update-qcs-api
branch
from
October 3, 2024 21:45
711240b
to
9cb3ead
Compare
|
BatmanAoD
force-pushed
the
update-qcs-api
branch
from
October 3, 2024 22:19
9cb3ead
to
67f777a
Compare
BatmanAoD
force-pushed
the
update-qcs-api
branch
3 times, most recently
from
October 8, 2024 23:32
e86f8f8
to
0dc582f
Compare
BatmanAoD
force-pushed
the
update-qcs-api
branch
from
October 9, 2024 00:05
0dc582f
to
fee4ccd
Compare
BatmanAoD
force-pushed
the
update-qcs-api
branch
from
October 9, 2024 00:07
fee4ccd
to
0a1efa2
Compare
MarquessV
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades networking & QCS libraries.
warp
hasn't upgraded tohyper=1
yet, but it's only a dev-dependency (and is explicitly denied in ourdeny.toml
); to confirm thathttp=0.2
is no longer a dependency for the actual build, run:Note: I think this works on its own, but I'd prefer to merge this first and update one minor version further: https://gitlab.com/rigetti/qcs/clients/qcs-api-client-rust/-/merge_requests/133