-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(coordinator): omit coordinator's error details to prover & add logs #863
Merged
0xmountaintop
merged 21 commits into
develop
from
feat-coordinator-hide-error-detail-in-prover-errmsg
Aug 24, 2023
Merged
refactor(coordinator): omit coordinator's error details to prover & add logs #863
0xmountaintop
merged 21 commits into
develop
from
feat-coordinator-hide-error-detail-in-prover-errmsg
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #863 +/- ##
========================================
Coverage 51.19% 51.19%
========================================
Files 60 60
Lines 5577 5577
========================================
Hits 2855 2855
Misses 2483 2483
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more. |
colinlyguo
force-pushed
the
feat-coordinator-hide-error-detail-in-prover-errmsg
branch
from
August 23, 2023 11:10
a56a165
to
574aa68
Compare
colinlyguo
deleted the
feat-coordinator-hide-error-detail-in-prover-errmsg
branch
August 23, 2023 11:11
colinlyguo
restored the
feat-coordinator-hide-error-detail-in-prover-errmsg
branch
August 23, 2023 11:11
colinlyguo
force-pushed
the
feat-coordinator-hide-error-detail-in-prover-errmsg
branch
from
August 23, 2023 11:23
9113128
to
f84e7ba
Compare
colinlyguo
changed the title
refactor(coordinator): remove error details to prover and add error logs
refactor(coordinator): remove coordinator error details to prover and add error logs
Aug 23, 2023
colinlyguo
changed the title
refactor(coordinator): remove coordinator error details to prover and add error logs
refactor(coordinator): omit coordinator's error details to prover & add logs
Aug 23, 2023
Thegaram
previously approved these changes
Aug 24, 2023
georgehao
previously approved these changes
Aug 24, 2023
Thegaram
previously approved these changes
Aug 24, 2023
0xmountaintop
approved these changes
Aug 24, 2023
0xmountaintop
deleted the
feat-coordinator-hide-error-detail-in-prover-errmsg
branch
August 24, 2023 14:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Mask db error details returned to provers.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated?Breaking change label
Does this PR have the
breaking-change
label?