Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(coordinator): omit coordinator's error details to prover & add logs #863

Merged

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Aug 23, 2023

Purpose or design rationale of this PR

Mask db error details returned to provers.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@colinlyguo colinlyguo self-assigned this Aug 23, 2023
@colinlyguo colinlyguo marked this pull request as ready for review August 23, 2023 09:39
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #863 (4710b7e) into develop (c44b7f7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #863   +/-   ##
========================================
  Coverage    51.19%   51.19%           
========================================
  Files           60       60           
  Lines         5577     5577           
========================================
  Hits          2855     2855           
  Misses        2483     2483           
  Partials       239      239           
Flag Coverage Δ
common 55.43% <ø> (ø)
coordinator 19.15% <ø> (ø)
database 42.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@colinlyguo colinlyguo closed this Aug 23, 2023
@colinlyguo colinlyguo force-pushed the feat-coordinator-hide-error-detail-in-prover-errmsg branch from a56a165 to 574aa68 Compare August 23, 2023 11:10
@colinlyguo colinlyguo deleted the feat-coordinator-hide-error-detail-in-prover-errmsg branch August 23, 2023 11:11
@colinlyguo colinlyguo restored the feat-coordinator-hide-error-detail-in-prover-errmsg branch August 23, 2023 11:11
@colinlyguo colinlyguo reopened this Aug 23, 2023
@colinlyguo colinlyguo force-pushed the feat-coordinator-hide-error-detail-in-prover-errmsg branch from 9113128 to f84e7ba Compare August 23, 2023 11:23
@colinlyguo colinlyguo changed the title refactor(coordinator): remove error details to prover and add error logs refactor(coordinator): remove coordinator error details to prover and add error logs Aug 23, 2023
@colinlyguo colinlyguo changed the title refactor(coordinator): remove coordinator error details to prover and add error logs refactor(coordinator): omit coordinator's error details to prover & add logs Aug 23, 2023
georgehao
georgehao previously approved these changes Aug 24, 2023
Thegaram
Thegaram previously approved these changes Aug 24, 2023
@colinlyguo colinlyguo dismissed stale reviews from Thegaram and georgehao via 39d4cd9 August 24, 2023 14:34
@0xmountaintop 0xmountaintop merged commit dab21fc into develop Aug 24, 2023
20 checks passed
@0xmountaintop 0xmountaintop deleted the feat-coordinator-hide-error-detail-in-prover-errmsg branch August 24, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants