refactor(coordinator): remove error details to prover and add error logs

scroll-tech · Aug 23, 2023 · 9113128 · 9113128
1 parent 574aa68
commit 9113128
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/coordinator/internal/controller/api/get_task.go b/coordinator/internal/controller/api/get_task.go
@@ -6,6 +6,7 @@ import (
 
 	"github.com/gin-gonic/gin"
 	"github.com/prometheus/client_golang/prometheus"
+	"github.com/scroll-tech/go-ethereum/log"
 	"gorm.io/gorm"
 
 	"scroll-tech/common/types"
@@ -55,8 +56,8 @@ func (ptc *GetTaskController) GetTasks(ctx *gin.Context) {
 
 	result, err := proverTask.Assign(ctx, &getTaskParameter)
 	if err != nil {
-		nerr := fmt.Errorf("return prover task err:%w", err)
-		coordinatorType.RenderJSON(ctx, types.ErrCoordinatorGetTaskFailure, nerr, nil)
+		log.Error("assign prover task failed", "err", err)
+		coordinatorType.RenderJSON(ctx, types.ErrCoordinatorGetTaskFailure, nil, nil)
 		return
 	}
 

diff --git a/coordinator/internal/types/response.go b/coordinator/internal/types/response.go
@@ -4,6 +4,8 @@ import (
 	"net/http"
 
 	"github.com/gin-gonic/gin"
+
+	"scroll-tech/common/types"
 )
 
 // Response the response schema
@@ -17,7 +19,11 @@ type Response struct {
 func RenderJSON(ctx *gin.Context, errCode int, err error, data interface{}) {
 	var errMsg string
 	if err != nil {
-		errMsg = err.Error()
+		if errCode == types.ErrCoordinatorGetTaskFailure {
+			errMsg = "Internal Server Error"
+		} else {
+			errMsg = err.Error()
+		}
 	}
 	renderData := Response{
 		ErrCode: errCode,