fix: Don't throw for 204 responses #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Feb 28, 2024
| @@ -41,7 +41,7 @@ async function parseResponse<T>(resp: Response): Promise<T> { | |||
| let json | |||
|
|
|||
| try { | |||
| json = await resp.json() | |||
| json = resp.status === 204 ? {} : await resp.json() | |||
There was a problem hiding this comment.
Could you add a comment here? I personally didn't know what 204 means and had to look it up.
katspaugh
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this solves
A 204 response doesn't contain a body so calling
response.json()will throw. This is caught locally and we check if there is acontent-length: 0header to cover the case of a 204 response. If there is no such header we throw again. The issue is that by default, the CGW returns 204 responses without such a header as it is not enforced.To solve this we are explicitely checking for a 204 status and don't call
response.json()in that case.