fix: Don't throw for 204 responses (#153)

* fix: Don't throw for 204 responses

* chore: Add comment for 204 status

src/utils.ts

@@ -41,7 +41,8 @@ async function parseResponse<T>(resp: Response): Promise<T> {
   let json
 
   try {
-    json = await resp.json()
+    // An HTTP 204 - No Content response doesn't contain a body so trying to call .json() on it would throw
+    json = resp.status === 204 ? {} : await resp.json()
   } catch {
     if (resp.headers && resp.headers.get('content-length') !== '0') {
       throw new Error(`Invalid response content: ${resp.statusText}`)

tests/utils.test.ts

@@ -197,5 +197,26 @@ describe('utils', () => {
         },
       })
     })
+
+    it('should not throw for a 204 response', async () => {
+      const jsonMock = jest.fn()
+      fetchMock.mockImplementation(() => {
+        return Promise.resolve({
+          ok: true,
+          status: 204,
+          json: jsonMock,
+        })
+      })
+
+      await expect(fetchData('/test/safe', 'DELETE')).resolves.toEqual({})
+      expect(jsonMock).not.toHaveBeenCalled()
+
+      expect(fetch).toHaveBeenCalledWith('/test/safe', {
+        method: 'DELETE',
+        headers: {
+          'Content-Type': 'application/json',
+        },
+      })
+    })
   })
 })