-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove redundant ids and userIdentifier when gbraid or wbraid are there #3910
base: develop
Are you sure you want to change the base?
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3910/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3910 +/- ##
========================================
Coverage 90.47% 90.48%
========================================
Files 615 615
Lines 32320 32343 +23
Branches 7677 7687 +10
========================================
+ Hits 29242 29265 +23
Misses 2822 2822
Partials 256 256 ☔ View full report in Codecov by Sentry. |
src/v0/destinations/google_adwords_offline_conversions/utils.js
Outdated
Show resolved
Hide resolved
4533bd7
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
What are the changes introduced in this PR?
We are doing the following changes:
Google ads
is accepting that. So we are not changing that behaviour, we just stopped throwing errors.What is the related Linear task?
Resolves INT-2942
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.