chore: address comment

rudderlabs · Dec 3, 2024 · 4d8e27b · 4d8e27b
1 parent 019da3a
commit 4d8e27b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/v0/destinations/google_adwords_offline_conversions/utils.js b/src/v0/destinations/google_adwords_offline_conversions/utils.js
@@ -361,7 +361,9 @@ const getClickConversionPayloadAndEndpoint = (
     set(payload, 'conversions[0].userIdentifiers[0].userIdentifierSource', UserIdentifierSource);
     // one of email or phone must be provided when none of gclid, wbraid and gbraid provided
     if (!email && !phone && !(gclid || wbraid || gbraid)) {
-      throw new InstrumentationError(`Either of email or phone is required for user identifier`);
+      throw new InstrumentationError(
+        `Either an email address or a phone number is required for user identification when none of gclid, wbraid, or gbraid is provided.`,
+      );
     }
   }
   // we are deleting userIdentifiers if any one of gclid, wbraid and gbraid is there but email or phone is not present

diff --git a/src/v0/destinations/google_adwords_offline_conversions/utils.test.js b/src/v0/destinations/google_adwords_offline_conversions/utils.test.js
@@ -244,7 +244,9 @@ describe('getClickConversionPayloadAndEndpoint util tests', () => {
     };
     expect(() =>
       getClickConversionPayloadAndEndpoint(fittingPayload, config, '9625812972'),
-    ).toThrow('Either of email or phone is required for user identifier');
+    ).toThrow(
+      'Either an email address or a phone number is required for user identification when none of gclid, wbraid, or gbraid is provided.',
+    );
   });
 
   it('finaliseConsent', () => {