-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bonk intake #89
base: offseason
Are you sure you want to change the base?
Add bonk intake #89
Conversation
Out of curiosity, does mech actually plan on putting an intake on bonk, or is this PR only for experimenting with new WPILib features? |
Mechanical is planning on putting an intake on Bonk during the Thursday meeting, we'll see how much time there is left in the meeting to test it. (The first time might very well be at BP, which would be okay) |
Mech is planning on attempting to put intake on bonk. The plan is that Mech will manufacture the intake on Thursday, leaving the actual attachment as the final step. If it doesn't look like there's going to be enough time, they won't attach the intake and will wait another week. I wrote this code both to test out new features and to have this code as a failsafe to deploy onto bonk if Kirby's training group doesn't get to writing their own version on Thursday. |
Got it. Design wise, is the bonk intake just a duplicate of the intake on crane? |
Probably should clean up git history before merging (or just squash merge)
Add bonk intake code. Went for a different architecture making this subsystem to test out some new things I wanted to try. For example, I tried out the command factory along with event loops. This code is untested.
Also remade the PR since it was previously including Joseph's code.
Edit: It still is including it in files changed for some reason?