-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Test suites for Zcb
sub extension from Code Size Reduction Extension (Zce)
#364
Conversation
2498815
to
a46836a
Compare
This needs the following checklist items completed:
|
I would love to use these tests on CORE-V Wally. It would be easiest when they are integrated into riscv-arch-test. @Abdulwadoodd, do you have an anticipated schedule about completing the checklist items to finish the PR? |
Hello prof. @davidharrishmc , generating coverage reports is a bit challenging for me due to the apparent lack of zcb support in ISAC's internal decoder. There were some alternatives highlighted in one of the sig-arch-test meetings. I will look to look into this and try to make it work by the end of the upcoming week. |
Coverage reports for the |
@allenjbaum , |
hello @allenjbaum, pinging for a review on this PR |
Signed-off-by: Abdul Wadood <abdulwadood.afzal88@gmail.com>
Signed-off-by: Abdul Wadood <abdulwadood.afzal88@gmail.com>
Signed-off-by: Abdul Wadood <abdulwadood.afzal88@gmail.com>
Signed-off-by: Abdul Wadood <abdulwadood.afzal88@gmail.com>
Signed-off-by: Abdul Wadood <abdulwadood.afzal88@gmail.com>
Signed-off-by: Abdul Wadood <abdulwadood.afzal88@gmail.com>
0e020db
to
123e218
Compare
modified version to avoid stale version number Signed-off-by: Allen Baum <31423142+allenjbaum@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manually updated version number to avoid duplicate
Thanks, @allenjbaum for approving the PR and pulling it in. |
Yea, I know.... I just don't know how to fix it, but it should be fixed (or
do it properly so you wouldn't have to).
I need to learn how to do this properly until we get a dev branch and
submitters don't have to worry about changelog dates and version numbers.
…On Mon, Dec 4, 2023 at 9:27 AM Abdul Wadood ***@***.***> wrote:
Thanks, @allenjbaum <https://github.com/allenjbaum> for approving the PR
and pulling it in.
In addition to "manually updating the version number", it would have also
required a "git rebase" to avoid the conflict and make a stable version
release through CI. CHANGELOG.md isn't chronologically correct at the
moment.
—
Reply to this email directly, view it on GitHub
<#364 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPXVJT4QUWXPHA26FCFU6TYHYBWVAVCNFSM6AAAAAAZNSG55GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZGEZDOOJVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Abdulwadoodd @allenjbaum @YazanHussnain-10x hello , I am trying to understand zcmp extension ( specifically cm.push and cm.pop instruction ) it would very helpful if you can share the config files and arch test files for the same |
Description
Code Size Reduction is the superset of the standard Compressed (C) extension. It consists of six sub-extensions:
Out of these six sub-extensions
zca
,zcf
,zcd
contains the instructions which are part of the standard C extension. Butzcb
,zcmp
,zcmt
sub extensions add new instructions.💡 Currently, this repository has test suites only for
zca
instructions.Changes
zcb
instructions, which is one of six sub-extensions of RISC-V Code Size Reduction.Related Pull Requests
Related Issues
Issue #334 and #6
Ratified/Unratified Extensions
Reference Model Used
Mandatory Checklist: